Minor optimizations to the Data Plane Computation #286
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also comment it and test it.
… changed This enables shallow copying, saving a significant amount of RAM and CPU in data plane computation for large networks.
Since the map we're looking into is a ConcurrentHashMap, this actually saves a significant amount of work.
|
Looks good to me. Probably best to have @arifogel's eyes on it too. |
|
Yes, will not merge until @arifogel gets back. |
arifogel
approved these changes
Aug 10, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simplify implementation of PrefixSpace#getAddressBits using helper methods and the fact that BitSet is already an array of longs under the hood.
Save a lookup in PrefixSpace#containsPrefix.
Since the
SortedSet<Integer>insideAsPathare never changed, make themImmutableSortedSetunder the hood. The key advantage of this is to save on copies:ImmutableSortedSet.copyOf(set)is a no-op ifsetis already anImmutableSortedSet.Combined, the two optimizations shave about 20% off of one large network data plane computation (8m13s [493s] down to 6m41s [401s]).
It took me a long time to convince myself that the sets inside of
AsPatharen't changed (and frankly, I may be wrong – but the tests pass). We would do well to add some proper Java abstractions here; based on what we do to these AsPaths in practice, it may expose other opportunities for improvement.