Set a default policy for iptables rules #294
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
dspicuzzbbn
commented
Aug 8, 2017
dspicuzzbbn
commented
- Fixes default Iptables chain policy should be ACCEPT #252
dhalperi
reviewed
Aug 9, 2017
| @@ -19,7 +19,7 @@ | |||
|
|
|||
| private String _name; | |||
|
|
|||
| private ChainPolicy _policy; | |||
There was a problem hiding this comment.
For consistency, can you please move this to the constructor, where _name and _rules are initialized?
dhalperi
requested changes
Aug 9, 2017
| @@ -19,7 +19,7 @@ | |||
|
|
|||
| private String _name; | |||
|
|
|||
| private ChainPolicy _policy; | |||
| private ChainPolicy _policy = ChainPolicy.ACCEPT; | |||
|
|
|||
| private List<IptablesRule> _rules; | |||
|
|
|||
There was a problem hiding this comment.
to test this, can you just delete the ACCEPT line from the existing testrig? Maybe just delete this line:
There was a problem hiding this comment.
@dhalperi deleting that line does not cause a test failure
There was a problem hiding this comment.
Never mind, I was only running the maven tests, I see now that travis does a bit more.
|
I'll try to get to the changes this week. |
dspicuzzbbn
force-pushed
the
iptables-default
branch
from
6d7d35e
to
5b531f6
Compare
dhalperi
approved these changes
Aug 17, 2017
|
Thanks @virtuald ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.