Environment validation for core and client #311
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- build fails due to coordinator unused declared dependency
…ronment-validation
…ronment-validation
…ronment-validation
…ronment-validation Resolve Ratul's conflicting init-environment implementation
arifogel
force-pushed
the
ari-environment-validation
branch
from
4a3e67a
to
b699e13
Compare
|
After painstaking merge, and with some small fixes, I believe it is working now. Due to changes to batfish test initialization routine, this PR is high priority. |
ratulm
approved these changes
Aug 26, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DO NOT MERGE WITHOUT TESTS