Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement F5 trunks (aggregate interfaces) #3339

Merged
merged 3 commits into from
Mar 6, 2019

Conversation

arifogel
Copy link
Member

@arifogel arifogel commented Mar 6, 2019

  • fix bug where every vlan's settings was applied to all interfaces

- fix bug where every vlan's settings was applied to all interfaces
@batfish-bot
Copy link

This change is Reviewable

@codecov
Copy link

codecov bot commented Mar 6, 2019

Codecov Report

Merging #3339 into master will increase coverage by 0.01%.
The diff coverage is 100%.

@@             Coverage Diff              @@
##             master    #3339      +/-   ##
============================================
+ Coverage     72.86%   72.87%   +0.01%     
- Complexity    23347    23357      +10     
============================================
  Files          2031     2032       +1     
  Lines         98088    98126      +38     
  Branches      11733    11733              
============================================
+ Hits          71472    71510      +38     
  Misses        21396    21396              
  Partials       5220     5220
Impacted Files Coverage Δ Complexity Δ
...uctured/F5BigipStructuredConfigurationBuilder.java 81.3% <100%> (+0.34%) 166 <3> (+3) ⬆️
...ava/org/batfish/representation/f5_bigip/Trunk.java 100% <100%> (ø) 3 <3> (?)
.../representation/f5_bigip/F5BigipConfiguration.java 94.69% <100%> (+0.18%) 149 <4> (+4) ⬆️
.../representation/f5_bigip/F5BigipStructureType.java 100% <100%> (ø) 3 <0> (ø) ⬇️
...representation/f5_bigip/F5BigipStructureUsage.java 100% <100%> (ø) 3 <0> (ø) ⬇️

Copy link
Contributor

@progwriter progwriter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 15 of 15 files at r1, 4 of 4 files at r2.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @arifogel, @corinaminer, and @sfraint)


projects/batfish-common-protocol/src/test/java/org/batfish/datamodel/matchers/InterfaceMatchers.java, line 159 at r2 (raw file):

  /**
   * Provides a matcher that matchs if the provided {@code subMatcher} matches the {@link

typo: matches

Copy link
Contributor

@progwriter progwriter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r3.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @corinaminer and @sfraint)

@arifogel arifogel merged commit 2ac6496 into batfish:master Mar 6, 2019
@arifogel arifogel deleted the ari-f5-trunks branch March 6, 2019 01:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants