Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

F5 virtual implement ip-protocol matching #3340

Merged
merged 1 commit into from
Mar 6, 2019

Conversation

arifogel
Copy link
Member

@arifogel arifogel commented Mar 6, 2019

No description provided.

@batfish-bot
Copy link

This change is Reviewable

@codecov
Copy link

codecov bot commented Mar 6, 2019

Codecov Report

Merging #3340 into master will increase coverage by <.01%.
The diff coverage is 100%.

@@             Coverage Diff              @@
##             master    #3340      +/-   ##
============================================
+ Coverage     72.85%   72.85%   +<.01%     
- Complexity    23341    23343       +2     
============================================
  Files          2031     2031              
  Lines         98084    98085       +1     
  Branches      11731    11732       +1     
============================================
+ Hits          71461    71463       +2     
  Misses        21399    21399              
+ Partials       5224     5223       -1
Impacted Files Coverage Δ Complexity Δ
.../representation/f5_bigip/F5BigipConfiguration.java 94.52% <100%> (+0.01%) 146 <0> (+1) ⬆️
...src/main/java/org/batfish/coordinator/PoolMgr.java 65.16% <0%> (+1.12%) 16% <0%> (+1%) ⬆️

Copy link
Contributor

@progwriter progwriter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 3 of 3 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @corinaminer and @sfraint)

@arifogel arifogel merged commit 88ff596 into batfish:master Mar 6, 2019
@arifogel arifogel deleted the ari-f5-virtual-ip-protocol branch March 6, 2019 02:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants