Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Juniper: don't try to generate transformations without an interface IP #3343

Merged
merged 3 commits into from
Mar 6, 2019

Conversation

anothermattbrown
Copy link
Contributor

This prevents NPE when an interface has no IP.

@batfish-bot
Copy link

This change is Reviewable

@codecov
Copy link

codecov bot commented Mar 6, 2019

Codecov Report

Merging #3343 into master will decrease coverage by <.01%.
The diff coverage is 50%.

@@             Coverage Diff              @@
##             master    #3343      +/-   ##
============================================
- Coverage     72.87%   72.87%   -0.01%     
+ Complexity    23339    23311      -28     
============================================
  Files          2031     2028       -3     
  Lines         98063    97995      -68     
  Branches      11724    11714      -10     
============================================
- Hits          71465    71409      -56     
+ Misses        21382    21380       -2     
+ Partials       5216     5206      -10
Impacted Files Coverage Δ Complexity Δ
...h/representation/juniper/JuniperConfiguration.java 88.89% <50%> (-0.43%) 361 <0> (+1)
...ipsecsessionstatus/IpsecSessionStatusQuestion.java 70.58% <0%> (-15.13%) 6% <0%> (ø)
...specifier/InterfaceNameRegexLocationSpecifier.java 53.33% <0%> (-13.34%) 4% <0%> (-1%)
...tfish/specifier/VrfNameRegexLocationSpecifier.java 53.33% <0%> (-13.34%) 4% <0%> (-1%)
...er/InterfaceDescriptionRegexLocationSpecifier.java 53.33% <0%> (-13.34%) 4% <0%> (-1%)
...rg/batfish/datamodel/questions/NodesSpecifier.java 71.31% <0%> (-7.38%) 37% <0%> (-2%)
...rc/main/java/org/batfish/datamodel/flow/Trace.java 73.33% <0%> (-6.67%) 8% <0%> (-1%)
...on/traceroute/BidirectionalTracerouteAnswerer.java 61.6% <0%> (-1.79%) 13% <0%> (ø)
...ipsecsessionstatus/IpsecSessionStatusAnswerer.java 57.77% <0%> (-0.65%) 12% <0%> (ø)
...ava/org/batfish/question/ReachabilitySettings.java 46.21% <0%> (-0.41%) 4% <0%> (ø)
... and 18 more

Copy link
Member

@arifogel arifogel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r2.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

Copy link
Member

@arifogel arifogel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@anothermattbrown anothermattbrown merged commit 9889646 into master Mar 6, 2019
@anothermattbrown anothermattbrown deleted the matt-juniper-transformation branch March 6, 2019 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants