Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

InterfaceProperties: return incoming filter name #3413

Merged
merged 2 commits into from
Mar 18, 2019

Conversation

progwriter
Copy link
Contributor

Return the name of the ACL/filter and not the contents

Return the name of the ACL/filter and not the contents
@batfish-bot
Copy link

This change is Reviewable

@codecov
Copy link

codecov bot commented Mar 18, 2019

Codecov Report

Merging #3413 into master will decrease coverage by <.01%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #3413      +/-   ##
============================================
- Coverage     73.03%   73.03%   -0.01%     
+ Complexity    23593    23590       -3     
============================================
  Files          2045     2045              
  Lines         98839    98839              
  Branches      11821    11821              
============================================
- Hits          72191    72183       -8     
- Misses        21397    21402       +5     
- Partials       5251     5254       +3
Impacted Files Coverage Δ Complexity Δ
...atamodel/questions/InterfacePropertySpecifier.java 100% <ø> (ø) 6 <0> (ø) ⬇️
...c/main/java/org/batfish/dataplane/rib/RibTree.java 78.72% <0%> (-10.64%) 23% <0%> (-1%)
...g/batfish/datamodel/acl/IpAccessListLineIndex.java 33.33% <0%> (-5.56%) 4% <0%> (-1%)
...in/java/org/batfish/dataplane/rib/AbstractRib.java 95.52% <0%> (-1.5%) 33% <0%> (-1%)
...col/src/main/java/org/batfish/role/InferRoles.java 90.62% <0%> (-0.4%) 68% <0%> (-1%)
...java/org/batfish/dataplane/ibdp/VirtualRouter.java 85.94% <0%> (-0.23%) 313% <0%> (-1%)
...src/main/java/org/batfish/datamodel/Interface.java 81.94% <0%> (+0.36%) 196% <0%> (+1%) ⬆️
...rc/main/java/org/batfish/datamodel/flow/Trace.java 80% <0%> (+6.66%) 9% <0%> (+1%) ⬆️

Copy link
Member

@dhalperi dhalperi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @corinaminer)


projects/batfish-common-protocol/src/main/java/org/batfish/datamodel/questions/InterfacePropertySpecifier.java, line 101 at r1 (raw file):

skip incoming filter

"use incomingFilterName instead of incomingFilter"

?

Copy link
Contributor Author

@progwriter progwriter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r2.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @corinaminer)

@progwriter progwriter merged commit f9a81d5 into batfish:master Mar 18, 2019
@progwriter progwriter deleted the ifaceprops-return-acl-name branch March 18, 2019 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants