Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Asa inline obj takeover #3416

Merged
merged 4 commits into from
Mar 19, 2019
Merged

Asa inline obj takeover #3416

merged 4 commits into from
Mar 19, 2019

Conversation

sfraint
Copy link
Member

@sfraint sfraint commented Mar 19, 2019

ASA extended access lists allow inline service specifier definitions in place of service objects, e.g.

access-list ACLNAME extended permit object icmp-echo any any
access-list ACLNAME extended permit object ospf any any

This PR is a takeover of #3241 from @mkremerbbn, adding support for these inline definitions.

mkremerbbn and others added 4 commits February 25, 2019 12:28
ASA extended access lists allow a service specifier in the form "object
NAME". It is possible to use a protocol name or icmp-type (e.g.
icmp-echo) in place of an explicit service object.
@batfish-bot
Copy link

This change is Reviewable

Copy link
Member Author

@sfraint sfraint left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 11 files reviewed, 1 unresolved discussion (waiting on @sfraint)

a discussion (no related file):
I will squash merge this w/ co-author comment once this PR is complete.


@sfraint sfraint requested a review from progwriter March 19, 2019 00:33
@codecov
Copy link

codecov bot commented Mar 19, 2019

Codecov Report

Merging #3416 into master will decrease coverage by <.01%.
The diff coverage is 94.44%.

@@             Coverage Diff              @@
##             master    #3416      +/-   ##
============================================
- Coverage     73.04%   73.04%   -0.01%     
- Complexity    23596    23613      +17     
============================================
  Files          2045     2045              
  Lines         98841    98895      +54     
  Branches      11821    11841      +20     
============================================
+ Hits          72203    72242      +39     
- Misses        21389    21400      +11     
- Partials       5249     5253       +4
Impacted Files Coverage Δ Complexity Δ
...isco/SimpleExtendedAccessListServiceSpecifier.java 82.81% <100%> (+1.77%) 6 <0> (ø) ⬇️
...fish/grammar/cisco/CiscoControlPlaneExtractor.java 66.55% <93.75%> (+0.21%) 1418 <19> (+21) ⬆️
...c/main/java/org/batfish/dataplane/rib/RibTree.java 78.72% <0%> (-10.64%) 23% <0%> (-1%)
...in/java/org/batfish/dataplane/rib/AbstractRib.java 95.52% <0%> (-1.5%) 33% <0%> (-1%)
...tfish/representation/cisco/CiscoConfiguration.java 83.52% <0%> (-0.34%) 520% <0%> (-4%)
...java/org/batfish/dataplane/ibdp/VirtualRouter.java 86.11% <0%> (-0.23%) 314% <0%> (-1%)
...src/main/java/org/batfish/coordinator/PoolMgr.java 65.16% <0%> (+1.12%) 16% <0%> (+1%) ⬆️
...col/src/main/java/org/batfish/role/InferRoles.java 91.79% <0%> (+1.17%) 69% <0%> (+1%) ⬆️

Copy link
Contributor

@progwriter progwriter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 6 files at r1, 10 of 10 files at r2.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @sfraint)

@sfraint sfraint merged commit b646bdf into master Mar 19, 2019
@sfraint sfraint deleted the spencer-asa-inline-obj-takeover branch March 19, 2019 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants