-
Notifications
You must be signed in to change notification settings - Fork 228
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Asa inline obj takeover #3416
Asa inline obj takeover #3416
Conversation
ASA extended access lists allow a service specifier in the form "object NAME". It is possible to use a protocol name or icmp-type (e.g. icmp-echo) in place of an explicit service object.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 11 files reviewed, 1 unresolved discussion (waiting on @sfraint)
a discussion (no related file):
I will squash merge this w/ co-author comment once this PR is complete.
Codecov Report
@@ Coverage Diff @@
## master #3416 +/- ##
============================================
- Coverage 73.04% 73.04% -0.01%
- Complexity 23596 23613 +17
============================================
Files 2045 2045
Lines 98841 98895 +54
Branches 11821 11841 +20
============================================
+ Hits 72203 72242 +39
- Misses 21389 21400 +11
- Partials 5249 5253 +4
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 6 files at r1, 10 of 10 files at r2.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @sfraint)
ASA extended access lists allow inline service specifier definitions in place of service objects, e.g.
This PR is a takeover of #3241 from @mkremerbbn, adding support for these inline definitions.