Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grammar for EIGRP metric weights #3418

Merged
merged 2 commits into from
Mar 19, 2019
Merged

Conversation

progwriter
Copy link
Contributor

Taking over #3240 that @mkremerbbn was working on.
Same content, with exception of making weights non-optional and linking to a doc. Could not find an example where weights are optional.

mkremerbbn and others added 2 commits March 18, 2019 17:56
The default setting for metric weights is supported, but setting the
them is not supported. Added parsing and a 'todo()' for weights which
allows consolidation of other related warnings. For configurations that
do not set actually set 'metric weights', no warning is necessary.
@progwriter progwriter requested a review from sfraint March 19, 2019 01:13
@batfish-bot
Copy link

This change is Reviewable

Copy link
Contributor Author

@progwriter progwriter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 8 files reviewed, all discussions resolved (waiting on @sfraint)


projects/batfish/src/main/java/org/batfish/grammar/cisco/CiscoControlPlaneExtractor.java, line 10262 at r2 (raw file):

  @Nullable
  @SuppressWarnings("unused")

@sfraint some parameters are unused so keeping the suppress for now.

@codecov
Copy link

codecov bot commented Mar 19, 2019

Codecov Report

Merging #3418 into master will decrease coverage by 0.01%.
The diff coverage is 62.5%.

@@             Coverage Diff              @@
##             master    #3418      +/-   ##
============================================
- Coverage     73.05%   73.03%   -0.02%     
+ Complexity    23597    23595       -2     
============================================
  Files          2045     2045              
  Lines         98841    98844       +3     
  Branches      11821    11820       -1     
============================================
- Hits          72204    72193      -11     
- Misses        21389    21400      +11     
- Partials       5248     5251       +3
Impacted Files Coverage Δ Complexity Δ
...fish/grammar/cisco/CiscoControlPlaneExtractor.java 66.28% <62.5%> (-0.07%) 1397 <2> (ø)
...c/main/java/org/batfish/dataplane/rib/RibTree.java 78.72% <0%> (-10.64%) 23% <0%> (-1%)
...in/java/org/batfish/dataplane/rib/AbstractRib.java 95.52% <0%> (-1.5%) 33% <0%> (-1%)
...col/src/main/java/org/batfish/role/InferRoles.java 90.62% <0%> (-0.4%) 68% <0%> (-1%)
...java/org/batfish/dataplane/ibdp/VirtualRouter.java 86.11% <0%> (-0.23%) 314% <0%> (-1%)
...src/main/java/org/batfish/coordinator/PoolMgr.java 65.16% <0%> (+1.12%) 16% <0%> (+1%) ⬆️

Copy link
Member

@sfraint sfraint left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 4 of 7 files at r1, 4 of 4 files at r2.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@progwriter progwriter merged commit 2d72410 into batfish:master Mar 19, 2019
@progwriter progwriter deleted the eigrp-weights branch March 19, 2019 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants