Rename testPolicies to testRoutePolicies

[anothermattbrown]

No description provided.

[batfish-bot]

This change is 

[codecov]

Codecov Report

Merging #3448 into master will not change coverage.
The diff coverage is 80%.

@@            Coverage Diff            @@
##             master    #3448   +/-   ##
=========================================
  Coverage     73.11%   73.11%           
  Complexity    23778    23778           
=========================================
  Files          2062     2062           
  Lines         99547    99547           
  Branches      11935    11935           
=========================================
  Hits          72784    72784           
  Misses        21428    21428           
  Partials       5335     5335

Impacted Files	Coverage Δ	Complexity Δ
...n/testroutepolicies/TestRoutePoliciesAnswerer.java	100% <ø> (ø)	8 <0> (?)
...tfish/question/testroutepolicies/BgpRouteDiff.java	84.9% <ø> (ø)	15 <0> (?)
...n/testroutepolicies/TestRoutePoliciesQuestion.java	96.29% <100%> (ø)	9 <1> (?)
...routepolicies/TestRoutePoliciesQuestionPlugin.java	66.66% <66.66%> (ø)	2 <2> (?)
...g/batfish/datamodel/acl/IpAccessListLineIndex.java	33.33% <0%> (-5.56%)	4% <0%> (-1%)
...src/main/java/org/batfish/coordinator/PoolMgr.java	65.16% <0%> (+1.12%)	16% <0%> (+1%)	⬆️

[ratulm]

I may have misled you -- it seems that we are using RoutingPolicy everywhere (e.g., in variable type and in internal classes) and not RoutePolicy. Worth it to make it consistent? Up to you.

Reviewed 9 of 13 files at r1, 3 of 3 files at r2.
Reviewable status: complete! all files reviewed, all discussions resolved

[ratulm]

Reviewable status: complete! all files reviewed, all discussions resolved