Cumulus NCLU vrf extraction

[arifogel]

• Harmonize naming restrictions and structure creation
  • bonds
  • interfaces
  • vrfs

[batfish-bot]

This change is 

[codecov]

Codecov Report

Merging #3501 into master will decrease coverage by <.01%.
The diff coverage is 88.23%.

@@             Coverage Diff              @@
##             master    #3501      +/-   ##
============================================
- Coverage     73.27%   73.26%   -0.01%     
- Complexity    24100    24124      +24     
============================================
  Files          2091     2092       +1     
  Lines        100531   100639     +108     
  Branches      12008    12025      +17     
============================================
+ Hits          73666    73736      +70     
- Misses        21484    21512      +28     
- Partials       5381     5391      +10

Impacted Files	Coverage Δ	Complexity Δ
...h/representation/cumulus/CumulusStructureType.java	100% <100%> (ø)	3 <0> (ø)	⬇️
...n/java/org/batfish/representation/cumulus/Vrf.java	100% <100%> (ø)	5 <5> (?)
.../representation/cumulus/CumulusStructureUsage.java	100% <100%> (ø)	3 <0> (ø)	⬇️
...presentation/cumulus/CumulusNcluConfiguration.java	100% <100%> (ø)	13 <1> (+1)	⬆️
.../org/batfish/representation/cumulus/Interface.java	96.55% <100%> (+0.39%)	17 <2> (+2)	⬆️
.../cumulus_nclu/CumulusNcluConfigurationBuilder.java	93.49% <85.71%> (-4.05%)	109 <29> (+29)
...c/main/java/org/batfish/dataplane/rib/RibTree.java	78.72% <0%> (-10.64%)	23% <0%> (-1%)
.../src/main/java/org/batfish/datamodel/flow/Hop.java	53.33% <0%> (-6.67%)	5% <0%> (-1%)
...g/batfish/datamodel/acl/IpAccessListLineIndex.java	33.33% <0%> (-5.56%)	4% <0%> (-1%)
...col/src/main/java/org/batfish/role/InferRoles.java	90.62% <0%> (-1.57%)	68% <0%> (-2%)
... and 5 more

[sfraint]

Reviewed 17 of 17 files at r1.
Reviewable status: complete! all files reviewed, all discussions resolved

---

projects/batfish/src/test/java/org/batfish/grammar/cumulus_nclu/CumulusNcluGrammarTest.java, line 303 at r1 (raw file):

    assertThat(ans, hasNumReferrers(filename, CumulusStructureType.VRF, "vrf1", 1));
    assertThat(ans, hasNumReferrers(filename, CumulusStructureType.VRF, "vrf2", 1));
    assertThat(ans, hasNumReferrers(filename, CumulusStructureType.VRF, "vrf3", 1));

could optionally add another vrf ref for one of these, so they aren't all 1

[arifogel]

Reviewable status: complete! all files reviewed, all discussions resolved

---

projects/batfish/src/test/java/org/batfish/grammar/cumulus_nclu/CumulusNcluGrammarTest.java, line 303 at r1 (raw file):

Previously, sfraint (Spencer Fraint) wrote…

    assertThat(ans, hasNumReferrers(filename, CumulusStructureType.VRF, "vrf1", 1));
    assertThat(ans, hasNumReferrers(filename, CumulusStructureType.VRF, "vrf2", 1));
    assertThat(ans, hasNumReferrers(filename, CumulusStructureType.VRF, "vrf3", 1));

could optionally add another vrf ref for one of these, so they aren't all 1

better now?

[sfraint]

Reviewed 3 of 4 files at r2, 4 of 4 files at r3.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @arifogel)

---

projects/batfish/src/main/java/org/batfish/grammar/cumulus_nclu/CumulusNcluConfigurationBuilder.java, line 559 at r3 (raw file):

initInterfacesIfAbsent

Do any calls to this need to pass null for usage?

[arifogel]

Reviewable status: 16 of 18 files reviewed, 1 unresolved discussion (waiting on @sfraint)

---

projects/batfish/src/main/java/org/batfish/grammar/cumulus_nclu/CumulusNcluConfigurationBuilder.java, line 559 at r3 (raw file):

Previously, sfraint (Spencer Fraint) wrote…

initInterfacesIfAbsent

Do any calls to this need to pass null for usage?

Yes.
enterA_interface does

[sfraint]

Reviewed 2 of 2 files at r4.
Reviewable status: complete! all files reviewed, all discussions resolved