Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

F5 BIG-IP imish extract bgp deterministic-med #3621

Merged

Conversation

arifogel
Copy link
Member

No description provided.

@arifogel arifogel requested a review from ratulm April 16, 2019 23:44
@batfish-bot
Copy link

This change is Reviewable

Copy link
Member Author

@arifogel arifogel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 10 files reviewed, 1 unresolved discussion (waiting on @ratulm)

a discussion (no related file):
After #3620 due to use of utility function introduced there.


@codecov
Copy link

codecov bot commented Apr 16, 2019

Codecov Report

Merging #3621 into master will increase coverage by 0.01%.
The diff coverage is 100%.

@@             Coverage Diff              @@
##             master    #3621      +/-   ##
============================================
+ Coverage     73.47%   73.49%   +0.01%     
- Complexity    24578    24604      +26     
============================================
  Files          2109     2109              
  Lines        101574   101624      +50     
  Branches      12054    12062       +8     
============================================
+ Hits          74635    74689      +54     
+ Misses        21548    21541       -7     
- Partials       5391     5394       +3
Impacted Files Coverage Δ Complexity Δ
..._bigip_imish/F5BigipImishConfigurationBuilder.java 89.86% <100%> (+0.09%) 53 <1> (+1) ⬆️
...rg/batfish/representation/f5_bigip/BgpProcess.java 100% <100%> (ø) 14 <2> (+2) ⬆️
.../org/batfish/specifier/parboiled/CommonParser.java 49.31% <0%> (-7.65%) 30% <0%> (-5%)
...va/org/batfish/datamodel/BgpSessionProperties.java 70.83% <0%> (-2.34%) 24% <0%> (+7%)
...ion/bgpsessionstatus/BgpSessionStatusAnswerer.java 56.29% <0%> (-1.25%) 13% <0%> (-1%)
...ish/specifier/parboiled/ParboiledAutoComplete.java 72.91% <0%> (-1%) 33% <0%> (+2%)
...ecifier/ReferenceAddressGroupIpSpaceSpecifier.java 53.84% <0%> (-1%) 4% <0%> (-1%)
...lient/src/main/java/org/batfish/client/Client.java 52.81% <0%> (-0.31%) 319% <0%> (ø)
...tfish/representation/cisco/CiscoConfiguration.java 83.88% <0%> (-0.13%) 528% <0%> (-1%)
...java/org/batfish/dataplane/ibdp/VirtualRouter.java 86.14% <0%> (-0.06%) 316% <0%> (ø)
... and 13 more

Copy link
Member

@ratulm ratulm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 10 of 10 files at r1.
Reviewable status: all files reviewed, 1 unresolved discussion

Copy link
Member Author

@arifogel arifogel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 8 of 10 files at r1, 1 of 1 files at r2.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@arifogel arifogel merged commit d1a45f0 into batfish:master Apr 17, 2019
@arifogel arifogel deleted the ari-f5-imish-bgp-deterministic-med-extraction branch April 17, 2019 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants