Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

F5 BIG-IP imish extract bgp neighbor next-hop-self #3622

Merged

Conversation

arifogel
Copy link
Member

No description provided.

@arifogel arifogel requested a review from ratulm April 17, 2019 00:03
@batfish-bot
Copy link

This change is Reviewable

Copy link
Member Author

@arifogel arifogel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 11 files reviewed, 1 unresolved discussion (waiting on @ratulm)

a discussion (no related file):
After #3620 due to use of utility function introduced there.


@codecov
Copy link

codecov bot commented Apr 17, 2019

Codecov Report

Merging #3622 into master will decrease coverage by <.01%.
The diff coverage is 100%.

@@             Coverage Diff              @@
##             master    #3622      +/-   ##
============================================
- Coverage     73.51%    73.5%   -0.01%     
+ Complexity    24613    24612       -1     
============================================
  Files          2109     2109              
  Lines        101624   101634      +10     
  Branches      12062    12062              
============================================
+ Hits          74707    74711       +4     
- Misses        21529    21532       +3     
- Partials       5388     5391       +3
Impacted Files Coverage Δ Complexity Δ
..._bigip_imish/F5BigipImishConfigurationBuilder.java 92.3% <100%> (+2.43%) 56 <2> (+3) ⬆️
...h/representation/f5_bigip/AbstractBgpNeighbor.java 100% <100%> (ø) 12 <2> (+2) ⬆️
...c/main/java/org/batfish/dataplane/rib/RibTree.java 78.72% <0%> (-10.64%) 23% <0%> (-1%)
...g/batfish/datamodel/acl/IpAccessListLineIndex.java 33.33% <0%> (-5.56%) 4% <0%> (-1%)
...in/java/org/batfish/dataplane/rib/AbstractRib.java 95.52% <0%> (-1.5%) 33% <0%> (-1%)
...col/src/main/java/org/batfish/role/InferRoles.java 91.79% <0%> (-0.4%) 69% <0%> (-1%)
...java/org/batfish/dataplane/ibdp/VirtualRouter.java 86.14% <0%> (-0.24%) 316% <0%> (-1%)

Copy link
Member

@ratulm ratulm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 11 of 11 files at r1.
Reviewable status: all files reviewed, 1 unresolved discussion

Copy link
Member Author

@arifogel arifogel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 4 of 9 files at r2.
Reviewable status: 5 of 8 files reviewed, all discussions resolved (waiting on @ratulm)

Copy link
Member Author

@arifogel arifogel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 9 files at r2.
Reviewable status: 6 of 8 files reviewed, all discussions resolved (waiting on @ratulm)

Copy link
Member

@ratulm ratulm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 9 files at r2.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@arifogel arifogel merged commit 986f4e1 into batfish:master Apr 17, 2019
@arifogel arifogel deleted the ari-f5-imish-bgp-next-hop-self-extraction branch April 17, 2019 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants