fix initial setting of origin type for juniper #363
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhalperi
approved these changes
Aug 25, 2017
| setOriginForNonBgp | ||
| .getTrueStatements() | ||
| BooleanExpr isNotBgp = new Not(isBgp); | ||
| setOriginForNonBgp.setGuard(isNotBgp); |
There was a problem hiding this comment.
reason for introducing isNotBgp instead of inlining in setGuard?
There was a problem hiding this comment.
Actually, could just use falseStatements instead of trueStatements
There was a problem hiding this comment.
For new BGP advertisements, i.e. those created from non-BGP routes, an origin code must be set. Juniper sets it to IGP by default. The code to do that was there, but there were two bugs:
- The condition was inverted.
- The If statement was never added to the policy.
dhalperi
approved these changes
Aug 26, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.