Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Arista BGP default-originate route-map #3696

Merged
merged 4 commits into from
Apr 24, 2019
Merged

Conversation

corinaminer
Copy link
Contributor

In the line:
neighbor 10.1.1.2 default-originate route-map ROUTE_MAP
Cisco uses ROUTE_MAP as a generation policy, but Arista instead applies it to the (unconditionally) exported default route (see Arista's documentation and notes from GNS3 for details). Currently Batfish always converts the route-map to a generation policy. This PR makes it add the route-map to the default route export policy instead if on an Arista device.

The default route export policy can now vary per peer again, so we're back to creating one default route export policy per default-originating peer, except for NXOS, which still creates one default route export policy per config.

@batfish-bot
Copy link

This change is Reviewable

@codecov
Copy link

codecov bot commented Apr 24, 2019

Codecov Report

Merging #3696 into master will decrease coverage by 0.01%.
The diff coverage is 84.84%.

@@             Coverage Diff              @@
##             master    #3696      +/-   ##
============================================
- Coverage     73.82%    73.8%   -0.02%     
+ Complexity    24836    24830       -6     
============================================
  Files          2118     2118              
  Lines        101662   101673      +11     
  Branches      12010    12013       +3     
============================================
- Hits          75047    75038       -9     
- Misses        21257    21273      +16     
- Partials       5358     5362       +4
Impacted Files Coverage Δ Complexity Δ
...tfish/representation/cisco/CiscoNxConversions.java 82.41% <100%> (ø) 39 <1> (ø) ⬇️
...tfish/representation/cisco/CiscoConfiguration.java 83.8% <75%> (-0.13%) 530 <1> (+2)
...batfish/representation/cisco/CiscoConversions.java 90.41% <89.47%> (+0.06%) 147 <3> (+1) ⬆️
...c/main/java/org/batfish/dataplane/rib/RibTree.java 78.72% <0%> (-10.64%) 23% <0%> (-1%)
.../src/main/java/org/batfish/datamodel/flow/Hop.java 53.33% <0%> (-6.67%) 5% <0%> (-1%)
...g/batfish/datamodel/acl/IpAccessListLineIndex.java 33.33% <0%> (-5.56%) 4% <0%> (-1%)
...rc/main/java/org/batfish/datamodel/flow/Trace.java 87.09% <0%> (-3.23%) 11% <0%> (-2%)
...org/batfish/datamodel/flow/BidirectionalTrace.java 81.81% <0%> (-2.28%) 14% <0%> (ø)
...col/src/main/java/org/batfish/role/InferRoles.java 91.01% <0%> (-1.18%) 69% <0%> (-1%)
...src/main/java/org/batfish/coordinator/PoolMgr.java 64.04% <0%> (-1.13%) 15% <0%> (-1%)
... and 2 more

Copy link
Contributor

@progwriter progwriter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 7 of 7 files at r1, 2 of 2 files at r2.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved


projects/batfish/src/test/java/org/batfish/grammar/cisco/CiscoGrammarTest.java, line 718 at r1 (raw file):

    BgpRoute expectedDefaultRoute =
        BgpRoute.builder()
            .setCommunities(ImmutableSet.of(7274718L, 21823932L))

darn it, creating more work for me 😛

@corinaminer corinaminer merged commit d2062ff into master Apr 24, 2019
@corinaminer corinaminer deleted the arista-bgp-default branch April 24, 2019 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants