-
Notifications
You must be signed in to change notification settings - Fork 228
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
only use allinone jar for packages #370
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved, with comments.
tools/package_rpm.sh
Outdated
ALLINONE_PROPERTIES_NAME=allinone.properties | ||
ALLINONE_PROPERTIES_SRC=$BATFISH_PATH/projects/allinone/target/classes/org/batfish/allinone/config/$ALLINONE_PROPERTIES_NAME | ||
ALLINONE_PROPERTIES=${CONF_DIR}/$ALLINONE_PROPERTIES_NAME | ||
BATFISH_PROPERTIES_P=${PBASE}${BATFISH_PROPERTIES} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fix to be ALLINONE_PROPERTIES_P
(and allinone properties on RHS too)
tools/package_ubuntu.sh
Outdated
ALLINONE_PROPERTIES_NAME=allinone.properties | ||
ALLINONE_PROPERTIES_SRC=$BATFISH_PATH/projects/allinone/target/classes/org/batfish/allinone/config/$ALLINONE_PROPERTIES_NAME | ||
ALLINONE_PROPERTIES=${CONF_DIR}/$ALLINONE_PROPERTIES_NAME | ||
BATFISH_PROPERTIES_P=${PBASE}${BATFISH_PROPERTIES} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fix to be ALLINONE_PROPERTIES_P
(and allinone properties on RHS too)
No description provided.