-
Notifications
You must be signed in to change notification settings - Fork 228
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Arista parsing for BGP redistribution into OSPF #3705
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3705 +/- ##
============================================
+ Coverage 73.8% 73.8% +<.01%
Complexity 24906 24906
============================================
Files 2119 2119
Lines 101845 101858 +13
Branches 12053 12054 +1
============================================
+ Hits 75167 75180 +13
- Misses 21266 21269 +3
+ Partials 5412 5409 -3
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
, but I know @arifogel had opinions. See if he wants to TAL before merging?
Reviewed 7 of 7 files at r1.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @arifogel)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
after discussing with @arifogel i took out the test config line redistribute bgp metric 10
, which wouldn't be valid for anybody, so i think we're all on the same page
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @arifogel)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 7 files at r1.
Reviewable status: complete! all files reviewed, all discussions resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 7 files at r1.
Reviewable status: complete! all files reviewed, all discussions resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: complete! all files reviewed, all discussions resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 7 files at r1.
Reviewable status: complete! all files reviewed, all discussions resolved
Creates a separate parse rule for Arista BGP redistribution into OSPF.
Arista syntax for redistributing BGP into OSPF is:
redistribute bgp
whereas Cisco vendors require an ASN:
redistribute bgp 65100
Both vendors allow configuring an optional route-map for BGP redistribution, but Cisco vendors also allow other options such as setting metric, metric-type, subnets, or tag.