Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Arista parsing for BGP redistribution into OSPF #3705

Merged
merged 3 commits into from
Apr 25, 2019
Merged

Conversation

corinaminer
Copy link
Contributor

Creates a separate parse rule for Arista BGP redistribution into OSPF.

Arista syntax for redistributing BGP into OSPF is:
redistribute bgp
whereas Cisco vendors require an ASN:
redistribute bgp 65100

Both vendors allow configuring an optional route-map for BGP redistribution, but Cisco vendors also allow other options such as setting metric, metric-type, subnets, or tag.

@batfish-bot
Copy link

This change is Reviewable

@codecov
Copy link

codecov bot commented Apr 25, 2019

Codecov Report

Merging #3705 into master will increase coverage by <.01%.
The diff coverage is 100%.

@@             Coverage Diff              @@
##             master    #3705      +/-   ##
============================================
+ Coverage      73.8%    73.8%   +<.01%     
  Complexity    24906    24906              
============================================
  Files          2119     2119              
  Lines        101845   101858      +13     
  Branches      12053    12054       +1     
============================================
+ Hits          75167    75180      +13     
- Misses        21266    21269       +3     
+ Partials       5412     5409       -3
Impacted Files Coverage Δ Complexity Δ
...fish/grammar/cisco/CiscoControlPlaneExtractor.java 66.57% <100%> (+0.12%) 1434 <2> (+4) ⬆️
.../src/main/java/org/batfish/datamodel/flow/Hop.java 53.33% <0%> (-6.67%) 5% <0%> (-1%)
...g/batfish/datamodel/acl/IpAccessListLineIndex.java 33.33% <0%> (-5.56%) 4% <0%> (-1%)
...col/src/main/java/org/batfish/role/InferRoles.java 91.01% <0%> (-1.18%) 69% <0%> (-1%)
...src/main/java/org/batfish/coordinator/PoolMgr.java 64.04% <0%> (-1.13%) 15% <0%> (-1%)
...org/batfish/grammar/BatfishParserATNSimulator.java 100% <0%> (+13.33%) 3% <0%> (+1%) ⬆️

Copy link
Member

@dhalperi dhalperi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm: , but I know @arifogel had opinions. See if he wants to TAL before merging?

Reviewed 7 of 7 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @arifogel)

Copy link
Contributor Author

@corinaminer corinaminer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

after discussing with @arifogel i took out the test config line redistribute bgp metric 10, which wouldn't be valid for anybody, so i think we're all on the same page

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @arifogel)

Copy link
Member

@arifogel arifogel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 7 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

Copy link
Member

@arifogel arifogel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 7 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

Copy link
Member

@arifogel arifogel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

Copy link
Member

@arifogel arifogel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 7 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@corinaminer corinaminer merged commit 4586b9a into master Apr 25, 2019
@corinaminer corinaminer deleted the arista-bgp-to-ospf branch April 25, 2019 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants