Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Intern OSPF routes #3728

Merged
merged 1 commit into from
Apr 29, 2019
Merged

Intern OSPF routes #3728

merged 1 commit into from
Apr 29, 2019

Conversation

progwriter
Copy link
Contributor

Helps reduce memory pressure in certain scenarios.

@batfish-bot
Copy link

This change is Reviewable

@codecov
Copy link

codecov bot commented Apr 29, 2019

Codecov Report

Merging #3728 into master will decrease coverage by <.01%.
The diff coverage is 100%.

@@             Coverage Diff              @@
##             master    #3728      +/-   ##
============================================
- Coverage     73.59%   73.58%   -0.01%     
- Complexity    24010    24012       +2     
============================================
  Files          2045     2045              
  Lines         98628    98632       +4     
  Branches      11902    11902              
============================================
+ Hits          72581    72583       +2     
- Misses        20702    20704       +2     
  Partials       5345     5345
Impacted Files Coverage Δ Complexity Δ
...java/org/batfish/datamodel/OspfIntraAreaRoute.java 82.6% <100%> (+3.06%) 17 <1> (+2) ⬆️
.../java/org/batfish/datamodel/OspfExternalRoute.java 84.21% <100%> (+1.54%) 19 <1> (+2) ⬆️
...java/org/batfish/datamodel/OspfInterAreaRoute.java 80.76% <100%> (+2.33%) 17 <1> (+2) ⬆️
...g/batfish/datamodel/acl/IpAccessListLineIndex.java 33.33% <0%> (-5.56%) 4% <0%> (-1%)
...col/src/main/java/org/batfish/role/InferRoles.java 91.01% <0%> (-1.18%) 69% <0%> (-1%)
...src/main/java/org/batfish/coordinator/PoolMgr.java 64.04% <0%> (-1.13%) 15% <0%> (-1%)

Copy link
Member

@dhalperi dhalperi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 3 of 3 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@dhalperi dhalperi merged commit 9fb95c8 into batfish:master Apr 29, 2019
anothermattbrown pushed a commit that referenced this pull request Apr 30, 2019
@progwriter progwriter deleted the intern-ospf-routes branch May 28, 2019 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants