Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misc simplifications #3766

Merged
merged 3 commits into from
May 1, 2019
Merged

Misc simplifications #3766

merged 3 commits into from
May 1, 2019

Conversation

dhalperi
Copy link
Member

@dhalperi dhalperi commented May 1, 2019

  • Shortcut expensive comparator for self-comparison.
  • Objects.equals(NotNull, NotNull) -> a.equals(b)
  • Box less

@dhalperi dhalperi requested a review from progwriter May 1, 2019 21:28
@batfish-bot
Copy link

This change is Reviewable

@dhalperi
Copy link
Member Author

dhalperi commented May 1, 2019

Last one for now, all in separate commits.

Copy link
Contributor

@progwriter progwriter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 11 of 11 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@codecov
Copy link

codecov bot commented May 1, 2019

Codecov Report

Merging #3766 into master will decrease coverage by <.01%.
The diff coverage is 95.23%.

@@             Coverage Diff              @@
##             master    #3766      +/-   ##
============================================
- Coverage     73.63%   73.63%   -0.01%     
+ Complexity    24060    24057       -3     
============================================
  Files          2047     2047              
  Lines         98852    98851       -1     
  Branches      11916    11914       -2     
============================================
- Hits          72790    72786       -4     
- Misses        20710    20711       +1     
- Partials       5352     5354       +2
Impacted Files Coverage Δ Complexity Δ
...ain/java/org/batfish/datamodel/AnnotatedRoute.java 51.85% <0%> (ø) 9 <0> (ø) ⬇️
.../org/batfish/dataplane/rib/RouteAdvertisement.java 92.85% <100%> (ø) 15 <0> (ø) ⬇️
...src/main/java/org/batfish/datamodel/Interface.java 78.84% <100%> (ø) 199 <0> (ø) ⬇️
...tfish/datamodel/collections/NodeInterfacePair.java 90.9% <100%> (-0.4%) 13 <0> (ø)
...rc/main/java/org/batfish/datamodel/IpWildcard.java 91.42% <100%> (ø) 34 <1> (ø) ⬇️
...java/org/batfish/datamodel/OspfIntraAreaRoute.java 84.61% <100%> (-0.57%) 18 <0> (ø)
...main/java/org/batfish/datamodel/AbstractRoute.java 88.23% <100%> (+0.73%) 12 <3> (+1) ⬆️
...g/batfish/datamodel/ospf/OspfNeighborConfigId.java 87.5% <100%> (ø) 16 <0> (ø) ⬇️
...java/org/batfish/datamodel/OspfInterAreaRoute.java 80.76% <100%> (ø) 17 <0> (ø) ⬇️
.../java/org/batfish/datamodel/ospf/OspfTopology.java 96% <100%> (ø) 17 <0> (ø) ⬇️
... and 7 more

@dhalperi dhalperi merged commit 0b1f014 into batfish:master May 1, 2019
@dhalperi dhalperi deleted the misc-simpl branch May 1, 2019 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants