VXLAN topology taking reachability into account

[arifogel]

No description provided.

[batfish-bot]

This change is 

[haverma]

Reviewed 2 of 2 files at r2.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @arifogel, @corinaminer, and @progwriter)

---

projects/batfish-common-protocol/src/main/java/org/batfish/datamodel/vxlan/VxlanTopologyUtils.java, line 176 at r2 (raw file):

      return false;
    }
    VniSettings vniSettingsV = nc.getVniSettings(hostV, vni).get();

do we not need to check the BumTransport method for vniSettingsV ?

---

projects/batfish-common-protocol/src/main/java/org/batfish/datamodel/vxlan/VxlanTopologyUtils.java, line 182 at r2 (raw file):

    Ip srcIpV = vniSettingsV.getSourceAddress();
    int udpPort = vniSettingsU.getUdpPort();
    return vxlanFlowDelivered(hostU, vrfU, srcIpU, hostV, srcIpV, udpPort, tracerouteEngine)

why don't we use bidirectional traceroute here as we do in BGP sessions reachability check ?

[arifogel]

Reviewable status: 1 of 2 files reviewed, 2 unresolved discussions (waiting on @corinaminer, @haverma, and @progwriter)

---

projects/batfish-common-protocol/src/main/java/org/batfish/datamodel/vxlan/VxlanTopologyUtils.java, line 176 at r2 (raw file):

Previously, haverma (Harsh Verma) wrote…

do we not need to check the BumTransport method for vniSettingsV ?

No, because as stated above,: nodeU and nodeV must be compatible coming into this function. This would imply they use the same transport method.

---

projects/batfish-common-protocol/src/main/java/org/batfish/datamodel/vxlan/VxlanTopologyUtils.java, line 182 at r2 (raw file):

Previously, haverma (Harsh Verma) wrote…

why don't we use bidirectional traceroute here as we do in BGP sessions reachability check ?

This is UDP, not TCP. There is no reverse/reply traffic.

[codecov]

Codecov Report

Merging #3823 into master will increase coverage by <.01%.
The diff coverage is 97.87%.

@@             Coverage Diff             @@
##             master   #3823      +/-   ##
===========================================
+ Coverage     73.99%     74%   +<.01%     
- Complexity    24160   24170      +10     
===========================================
  Files          2039    2039              
  Lines         98087   98135      +48     
  Branches      11755   11762       +7     
===========================================
+ Hits          72579   72620      +41     
  Misses        20230   20230              
- Partials       5278    5285       +7

Impacted Files	Coverage Δ	Complexity Δ
...rg/batfish/datamodel/vxlan/VxlanTopologyUtils.java	98.05% <97.87%> (-1.95%)	47 <14> (+15)
...ain/java/org/batfish/symbolic/state/PostInVrf.java	78.57% <0%> (-7.15%)	7% <0%> (-1%)
...rc/main/java/org/batfish/datamodel/flow/Trace.java	87.09% <0%> (-3.23%)	12% <0%> (-1%)
...ain/java/org/batfish/symbolic/IngressLocation.java	65.78% <0%> (-2.64%)	15% <0%> (-1%)
...src/main/java/org/batfish/coordinator/PoolMgr.java	64.04% <0%> (-1.13%)	15% <0%> (-1%)
...col/src/main/java/org/batfish/role/InferRoles.java	90.23% <0%> (-0.4%)	67% <0%> (-1%)

[haverma]

Reviewed 1 of 1 files at r3.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @corinaminer and @progwriter)