-
Notifications
You must be signed in to change notification settings - Fork 228
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix misc cisco parsing errors #388
Conversation
@@ -71,6 +71,7 @@ l_null | |||
| FLUSH_AT_ACTIVATION | |||
| HISTORY | |||
| IPV6 | |||
| LENGTH DEC |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will conflict with #392
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, Dustin! I'll make sure we handle your PR first.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left notes for our team to fix later, but I am approving and merging.
@@ -880,6 +882,7 @@ null_single | |||
| CONFIGURATION | |||
| DOT1Q | |||
| INTERNAL | |||
| IFDESCR DETAIL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be double-parenthesized for style matching, maintainability.
@@ -1920,6 +1948,14 @@ s_voice | |||
)* | |||
; | |||
|
|||
s_voice_card |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
VOICE_CARD
must be removed from null_single
@@ -1227,6 +1234,15 @@ router_multicast_tail | |||
)* | |||
; | |||
|
|||
s_application |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does order matter here? Can we use the regular hierarchical style here?
@@ -71,6 +71,7 @@ l_null | |||
| FLUSH_AT_ACTIVATION | |||
| HISTORY | |||
| IPV6 | |||
| LENGTH DEC |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be double-parenthesized for style matching, maintainability.
No description provided.