Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parsing rsa-encr authentication method in IKE #3971

Merged
merged 6 commits into from
May 29, 2019
Merged

Parsing rsa-encr authentication method in IKE #3971

merged 6 commits into from
May 29, 2019

Conversation

haverma
Copy link

@haverma haverma commented May 29, 2019

parsing RSA encryption authentication method in Cisco IOS's ISAKMP policy
ISAKMP policy is stored in VI model's IkePhase1Proposal

@batfish-bot
Copy link

This change is Reviewable

@haverma haverma requested a review from progwriter May 29, 2019 19:58
@haverma haverma changed the title Parsing RSA encryption authentication in IKE Parsing RSA authentication in IKE May 29, 2019
@haverma haverma changed the title Parsing RSA authentication in IKE Parsing rsa-encr authentication method in IKE May 29, 2019
@codecov
Copy link

codecov bot commented May 29, 2019

Codecov Report

Merging #3971 into master will increase coverage by <.01%.
The diff coverage is 100%.

@@             Coverage Diff              @@
##             master    #3971      +/-   ##
============================================
+ Coverage     74.94%   74.94%   +<.01%     
- Complexity    24263    24267       +4     
============================================
  Files          2031     2031              
  Lines         97285    97295      +10     
  Branches      11590    11591       +1     
============================================
+ Hits          72909    72922      +13     
+ Misses        19097    19091       -6     
- Partials       5279     5282       +3
Impacted Files Coverage Δ Complexity Δ
...org/batfish/datamodel/IkeAuthenticationMethod.java 100% <100%> (ø) 1 <0> (ø) ⬇️
...fish/grammar/cisco/CiscoControlPlaneExtractor.java 66.66% <100%> (+0.01%) 1437 <0> (+1) ⬆️
...c/main/java/org/batfish/dataplane/rib/RibTree.java 89.79% <0%> (-4.09%) 27% <0%> (-1%)
...ava/org/batfish/datamodel/bgp/Layer2VniConfig.java 85.71% <0%> (-2.86%) 15% <0%> (-1%)
...col/src/main/java/org/batfish/role/InferRoles.java 91.24% <0%> (-1.1%) 68% <0%> (-1%)
...java/org/batfish/dataplane/ibdp/VirtualRouter.java 88.22% <0%> (-0.22%) 245% <0%> (-1%)
...tfish/representation/cisco/CiscoConfiguration.java 83.92% <0%> (+0.12%) 531% <0%> (+1%) ⬆️
.../cumulus_nclu/CumulusNcluConfigurationBuilder.java 88.54% <0%> (+0.13%) 210% <0%> (+2%) ⬆️
...presentation/cumulus/CumulusNcluConfiguration.java 95.3% <0%> (+0.78%) 130% <0%> (+2%) ⬆️
...ain/java/org/batfish/symbolic/IngressLocation.java 68.42% <0%> (+2.63%) 16% <0%> (+1%) ⬆️
... and 1 more

Copy link
Contributor

@progwriter progwriter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 5 of 6 files at r1, 1 of 1 files at r2, 1 of 1 files at r3.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @haverma)


projects/batfish/src/main/antlr4/org/batfish/grammar/cisco/CiscoLexer.g4, line 11016 at r2 (raw file):

RSA_ENCR
:
 'rsa-encr'

nit: whitespace indentation is different here than elsewhere.

Copy link
Author

@haverma haverma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r4.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved


projects/batfish/src/main/antlr4/org/batfish/grammar/cisco/CiscoLexer.g4, line 11016 at r2 (raw file):

Previously, progwriter (Victor Heorhiadi) wrote…

nit: whitespace indentation is different here than elsewhere.

thanks for catching, fixed

@haverma haverma merged commit 2e6ca42 into master May 29, 2019
@haverma haverma deleted the auth-rsa-encr branch May 29, 2019 22:51
agember pushed a commit to colgate-cs-research/batfish that referenced this pull request Jun 11, 2019
* isakmp policy authentication rsa-encr

* expect all IKE P1 proposals in tests, add TODO
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants