-
Notifications
You must be signed in to change notification settings - Fork 228
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Parsing rsa-encr authentication method in IKE #3971
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3971 +/- ##
============================================
+ Coverage 74.94% 74.94% +<.01%
- Complexity 24263 24267 +4
============================================
Files 2031 2031
Lines 97285 97295 +10
Branches 11590 11591 +1
============================================
+ Hits 72909 72922 +13
+ Misses 19097 19091 -6
- Partials 5279 5282 +3
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 5 of 6 files at r1, 1 of 1 files at r2, 1 of 1 files at r3.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @haverma)
projects/batfish/src/main/antlr4/org/batfish/grammar/cisco/CiscoLexer.g4, line 11016 at r2 (raw file):
RSA_ENCR : 'rsa-encr'
nit: whitespace indentation is different here than elsewhere.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r4.
Reviewable status: complete! all files reviewed, all discussions resolved
projects/batfish/src/main/antlr4/org/batfish/grammar/cisco/CiscoLexer.g4, line 11016 at r2 (raw file):
Previously, progwriter (Victor Heorhiadi) wrote…
nit: whitespace indentation is different here than elsewhere.
thanks for catching, fixed
* isakmp policy authentication rsa-encr * expect all IKE P1 proposals in tests, add TODO
parsing RSA encryption authentication method in Cisco IOS's ISAKMP policy
ISAKMP policy is stored in VI model's
IkePhase1Proposal