Palo Alto Static Route with next-vr conversion #4101
Conversation
|
This change is |
There was a problem hiding this comment.
Reviewed 7 of 7 files at r1.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @sfraint)
There was a problem hiding this comment.
Reviewed 1 of 1 files at r2.
Reviewable status:
There was a problem hiding this comment.
Reviewed 7 of 7 files at r3.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @arifogel and @sfraint)
projects/batfish/src/test/resources/org/batfish/grammar/palo_alto/testconfigs/static-route, line 9 at r3 (raw file):
set network virtual-router vr2 routing-table ip static-route ROUTE2 destination 0.0.0.0/0 set network virtual-router vr2 routing-table ip static-route ROUTE2 nexthop next-vr fakevr set network virtual-router vr2 routing-table ip static-route ROUTE2 nexthop next-vr fakevr
this line duplicate of the line right above?
tests/parsing-tests/unit-tests-undefined.ref, line 3849 at r3 (raw file):
"Struct_Type" : "interface", "Ref_Name" : "dummy", "Context" : "virtual-router interface",
confused as to why fakevr isn't the undefined ref here
There was a problem hiding this comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @progwriter and @sfraint)
projects/batfish/src/test/resources/org/batfish/grammar/palo_alto/testconfigs/static-route, line 9 at r3 (raw file):
Previously, progwriter (Victor Heorhiadi) wrote…
this line duplicate of the line right above?
removed
There was a problem hiding this comment.
Reviewed 1 of 1 files at r4.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @progwriter and @sfraint)
Codecov Report
@@ Coverage Diff @@
## master #4101 +/- ##
=========================================
Coverage 75.09% 75.09%
Complexity 24574 24574
=========================================
Files 2021 2021
Lines 98428 98428
Branches 11690 11690
=========================================
Hits 73913 73913
Misses 19195 19195
Partials 5320 5320 |
There was a problem hiding this comment.
Reviewed 1 of 1 files at r5.
Reviewable status:
No description provided.