Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More cadant, various fixes #411

Merged
merged 49 commits into from
Sep 5, 2017
Merged

More cadant, various fixes #411

merged 49 commits into from
Sep 5, 2017

Conversation

arifogel
Copy link
Member

@arifogel arifogel commented Sep 5, 2017

Not sure why merged commits are showing. Anyway, here is the rest of the CMTS stuff, and some other fixes.
I believe you only need to look at 8d7ce68 and later.

@arifogel arifogel closed this Sep 5, 2017
@arifogel arifogel reopened this Sep 5, 2017
Copy link
Member

@dhalperi dhalperi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Went though commit-by-commit and seems reasonable.

@dhalperi dhalperi merged commit f986f43 into master Sep 5, 2017
@dhalperi dhalperi deleted the ari-parsing branch September 5, 2017 17:55
@dhalperi
Copy link
Member

dhalperi commented Sep 5, 2017

I believe the old commits showed up because you didn't start a fresh branch forked from master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants