Cisco interface parsing: allow secondary HSRP address

[progwriter]

No description provided.

[batfish-bot]

This change is 

[codecov]

Codecov Report

Merging #4186 into master will decrease coverage by <.01%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #4186      +/-   ##
============================================
- Coverage     75.32%   75.31%   -0.01%     
+ Complexity    24947    24944       -3     
============================================
  Files          2046     2046              
  Lines         99604    99604              
  Branches      11839    11839              
============================================
- Hits          75022    75016       -6     
- Misses        19209    19212       +3     
- Partials       5373     5376       +3

Impacted Files	Coverage Δ	Complexity Δ
...java/org/batfish/symbolic/state/EdgeStateExpr.java	80.95% <0%> (-4.77%)	10% <0%> (-1%)
...rc/main/java/org/batfish/bddreachability/Edge.java	67.64% <0%> (-2.95%)	11% <0%> (-1%)
...src/main/java/org/batfish/coordinator/PoolMgr.java	64.04% <0%> (-1.13%)	15% <0%> (-1%)
...tfish/representation/cisco/CiscoConfiguration.java	83.96% <0%> (-0.13%)	530% <0%> (-1%)

[arifogel]

Reviewed 4 of 4 files at r1.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @progwriter)

a discussion (no related file):
What impact does this have? I see no data model changes nor tests. Do we not process HSRP currently? Are you ignoring distinction between primary and secondary HSRP addresses?

---

[progwriter]

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @arifogel)

a discussion (no related file):

Previously, arifogel (Ari Fogel) wrote…

What impact does this have? I see no data model changes nor tests. Do we not process HSRP currently? Are you ignoring distinction between primary and secondary HSRP addresses?

The extractor has no logic of any if_hsrp stanzas; we only handle standby stanzas. Cursory search suggests it is an ios/nxos difference.

Happy to flesh out extraction/conversion, but best in separate PR.

---

[arifogel]

Reviewable status: complete! all files reviewed, all discussions resolved