Cumulus: support for interface aliases

[progwriter]

Convert them to descriptions

[batfish-bot]

This change is 

[codecov]

Codecov Report

Merging #4192 into master will decrease coverage by 0.01%.
The diff coverage is 100%.

@@             Coverage Diff              @@
##             master    #4192      +/-   ##
============================================
- Coverage     75.36%   75.34%   -0.02%     
+ Complexity    25366    24994     -372     
============================================
  Files          2046     2046              
  Lines        100804    99767    -1037     
  Branches      12079    11862     -217     
============================================
- Hits          75970    75169     -801     
+ Misses        19403    19217     -186     
+ Partials       5431     5381      -50

Impacted Files	Coverage Δ	Complexity Δ
.../cumulus_nclu/CumulusNcluConfigurationBuilder.java	86% <100%> (+0.03%)	242 <1> (+1)	⬆️
...presentation/cumulus/CumulusNcluConfiguration.java	95.68% <100%> (ø)	140 <0> (ø)	⬇️
.../org/batfish/representation/cumulus/Interface.java	100% <100%> (ø)	16 <2> (+2)	⬆️
...atfish/datamodel/answers/InputValidationUtils.java	48.14% <0%> (-11.12%)	8% <0%> (-5%)
...tamodel/questions/BgpProcessPropertySpecifier.java	86.48% <0%> (-10.29%)	7% <0%> (-4%)
...del/questions/NamedStructurePropertySpecifier.java	87.87% <0%> (-9.56%)	4% <0%> (-2%)
.../datamodel/questions/BgpPeerPropertySpecifier.java	84% <0%> (-7.57%)	16% <0%> (-7%)
...h/specifier/parboiled/ParboiledInputValidator.java	74.62% <0%> (-7.47%)	10% <0%> (-1%)
...uestion/nodeproperties/NodePropertiesQuestion.java	86.66% <0%> (-5.65%)	6% <0%> (-4%)
...g/batfish/datamodel/acl/IpAccessListLineIndex.java	33.33% <0%> (-5.56%)	4% <0%> (-1%)
... and 13 more

[arifogel]

Reviewed 7 of 7 files at r1.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @progwriter)

---

projects/batfish/src/main/java/org/batfish/representation/cumulus/Interface.java, line 82 at r1 (raw file):

  }

  public Interface setAlias(@Nullable String alias) {

Why does this return an Interface? It's the only function that does in this class.

[progwriter]

Reviewable status: 6 of 7 files reviewed, all discussions resolved (waiting on @arifogel)

---

projects/batfish/src/main/java/org/batfish/representation/cumulus/Interface.java, line 82 at r1 (raw file):

Previously, arifogel (Ari Fogel) wrote…

Why does this return an Interface? It's the only function that does in this class.

Wrong template generation. fixed.

[arifogel]

Reviewed 1 of 1 files at r2.
Reviewable status: complete! all files reviewed, all discussions resolved

[arifogel]

Reviewable status: complete! all files reviewed, all discussions resolved