Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add extended community field, use in dataplane #4193

Merged
merged 1 commit into from
Jul 4, 2019

Conversation

progwriter
Copy link
Contributor

No description provided.

@progwriter progwriter requested a review from arifogel July 4, 2019 01:17
@batfish-bot
Copy link

This change is Reviewable

Copy link
Member

@arifogel arifogel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 11 of 11 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@codecov
Copy link

codecov bot commented Jul 4, 2019

Codecov Report

Merging #4193 into master will decrease coverage by 0.01%.
The diff coverage is 94.59%.

@@             Coverage Diff              @@
##             master    #4193      +/-   ##
============================================
- Coverage     75.36%   75.34%   -0.02%     
+ Complexity    25367    24997     -370     
============================================
  Files          2046     2046              
  Lines        100804    99789    -1015     
  Branches      12079    11865     -214     
============================================
- Hits          75971    75190     -781     
+ Misses        19403    19216     -187     
+ Partials       5430     5383      -47
Impacted Files Coverage Δ Complexity Δ
.../src/main/java/org/batfish/datamodel/BgpRoute.java 87.39% <100%> (+1.41%) 24 <2> (+2) ⬆️
...h/representation/juniper/JuniperConfiguration.java 89.26% <100%> (ø) 377 <0> (ø) ⬇️
...presentation/cumulus/CumulusNcluConfiguration.java 95.72% <100%> (+0.04%) 140 <0> (ø) ⬇️
...batfish/dataplane/protocols/BgpProtocolHelper.java 94.69% <83.33%> (-0.81%) 37 <0> (+1)
...tfish/datamodel/bgp/AddressFamilyCapabilities.java 89.65% <90%> (-0.22%) 26 <2> (+2)
...atfish/datamodel/answers/InputValidationUtils.java 48.14% <0%> (-11.12%) 8% <0%> (-5%)
...tamodel/questions/BgpProcessPropertySpecifier.java 86.48% <0%> (-10.29%) 7% <0%> (-4%)
...del/questions/NamedStructurePropertySpecifier.java 87.87% <0%> (-9.56%) 4% <0%> (-2%)
.../datamodel/questions/BgpPeerPropertySpecifier.java 84% <0%> (-7.57%) 16% <0%> (-7%)
...h/specifier/parboiled/ParboiledInputValidator.java 74.62% <0%> (-7.47%) 10% <0%> (-1%)
... and 15 more

@progwriter progwriter merged commit f6c8c79 into batfish:master Jul 4, 2019
@progwriter progwriter deleted the send-extended-community branch July 4, 2019 01:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants