PluginConsumer: fix a number of bugs #422
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Inability to handle serialized objects bigger than 2GB 2. Leaked streams The fix for 1 involves not reading the data into an array before passing it to the deserializer. The fix for 2 involves making sure we close streams, even in exception cases. Guava's Closer makes this easier, although it still throws IOException which makes integration with Batfish's exception policies more challenging.
dhalperi
commented
Sep 8, 2017
| } | ||
|
|
||
| protected byte[] fromGzipFile(Path inputFile) { | ||
| try { | ||
| FileInputStream fis = new FileInputStream(inputFile.toFile()); | ||
| GZIPInputStream gis = new GZIPInputStream(fis); | ||
| byte[] data = IOUtils.toByteArray(gis); |
There was a problem hiding this comment.
This file stream was leaked -- IOUtils.toByteArray does not close the input stream.
ratulm
approved these changes
Sep 9, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The fix for 1 involves not reading the data into an array before
passing it to the deserializer.
The fix for 2 involves making sure we close streams, even in exception cases.
Guava's Closer makes this easier, although it still throws IOException which
makes integration with Batfish's exception policies more challenging.