Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IOS-XR: missing reference for route-policy apply #4237

Merged
merged 1 commit into from
Jul 10, 2019

Conversation

dhalperi
Copy link
Member

Fix #4227

@dhalperi dhalperi requested a review from haverma July 10, 2019 20:54
@batfish-bot
Copy link

This change is Reviewable

Copy link

@haverma haverma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 5 of 5 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@codecov
Copy link

codecov bot commented Jul 10, 2019

Codecov Report

Merging #4237 into master will decrease coverage by 0.16%.
The diff coverage is 100%.

@@             Coverage Diff              @@
##             master    #4237      +/-   ##
============================================
- Coverage     75.42%   75.25%   -0.17%     
+ Complexity    25456    25366      -90     
============================================
  Files          2070     2070              
  Lines        101247   101251       +4     
  Branches      12147    12147              
============================================
- Hits          76362    76193     -169     
- Misses        19383    19563     +180     
+ Partials       5502     5495       -7
Impacted Files Coverage Δ Complexity Δ
...tfish/representation/cisco/CiscoConfiguration.java 84.08% <ø> (ø) 531 <0> (ø) ⬇️
...fish/representation/cisco/CiscoStructureUsage.java 100% <100%> (ø) 3 <0> (ø) ⬇️
...fish/grammar/cisco/CiscoControlPlaneExtractor.java 66.88% <100%> (+0.01%) 1463 <1> (ø) ⬇️
...atfish/bddreachability/transition/Transitions.java 0% <0%> (-95.17%) 0% <0%> (-93%)
...java/org/batfish/dataplane/ibdp/VirtualRouter.java 88.7% <0%> (+0.21%) 255% <0%> (+1%) ⬆️
...c/main/java/org/batfish/dataplane/rib/RibTree.java 93.87% <0%> (+4.08%) 28% <0%> (+1%) ⬆️

@haverma haverma merged commit e8eb712 into batfish:master Jul 10, 2019
@dhalperi dhalperi deleted the rpl-sub-policy branch July 10, 2019 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

IOS XR RPL Sub-Policies Are "Unused References"
3 participants