Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ASA: allow service-object with implicit destination #4278

Merged
merged 1 commit into from
Jul 18, 2019

Conversation

dhalperi
Copy link
Member

Though it will show with "definition", ASA at least 9.7(1) allows you to skip
that clause when defining service objects:

If you enter this:

object-group service service-ssh
 service-object tcp eq ssh
 service-object tcp source eq www eq ftp

It will be acceped and show as this:

object-group service service-ssh
 service-object tcp destination eq ssh
 service-object tcp source eq www destination eq ftp

Though it will show with "definition", ASA at least 9.7(1) allows you to skip
that clause when defining service objects:

If you enter this:

    object-group service service-ssh
     service-object tcp eq ssh
     service-object tcp source eq www eq ftp

It will be acceped and show as this:

    object-group service service-ssh
     service-object tcp destination eq ssh
     service-object tcp source eq www destination eq ftp
@batfish-bot
Copy link

This change is Reviewable

@codecov
Copy link

codecov bot commented Jul 18, 2019

Codecov Report

Merging #4278 into master will decrease coverage by <.01%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #4278      +/-   ##
============================================
- Coverage     75.46%   75.46%   -0.01%     
+ Complexity    25802    25800       -2     
============================================
  Files          2105     2105              
  Lines        102343   102343              
  Branches      12269    12269              
============================================
- Hits          77235    77230       -5     
- Misses        19503    19507       +4     
- Partials       5605     5606       +1
Impacted Files Coverage Δ Complexity Δ
...src/main/java/org/batfish/coordinator/PoolMgr.java 59.55% <0%> (-4.5%) 13% <0%> (-2%)
...java/org/batfish/symbolic/state/EdgeStateExpr.java 73.91% <0%> (-4.35%) 10% <0%> (-1%)
...ain/java/org/batfish/coordinator/WorkQueueMgr.java 70.84% <0%> (-0.59%) 90% <0%> (-1%)
...col/src/main/java/org/batfish/role/InferRoles.java 91.24% <0%> (-0.37%) 68% <0%> (-1%)
...src/main/java/org/batfish/coordinator/WorkMgr.java 69.04% <0%> (-0.28%) 277% <0%> (-1%)
...fish/grammar/cisco/CiscoControlPlaneExtractor.java 66.92% <0%> (+0.02%) 1465% <0%> (+2%) ⬆️
...tfish/representation/cisco/CiscoConfiguration.java 84.08% <0%> (+0.12%) 531% <0%> (+1%) ⬆️
...ocol/src/main/java/org/batfish/datamodel/Flow.java 82.9% <0%> (+0.72%) 74% <0%> (+2%) ⬆️

Copy link
Contributor

@progwriter progwriter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 7 of 7 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @arifogel and @sfraint)

@dhalperi dhalperi merged commit 35e8a03 into batfish:master Jul 18, 2019
@dhalperi dhalperi deleted the asa-service-object branch July 18, 2019 05:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants