Cisco: convert src/dst addresses for tunnel interfaces

[progwriter]

Pre-req for #4280

[batfish-bot]

This change is 

[haverma]

Reviewed 5 of 5 files at r1.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @progwriter)

---

projects/batfish/src/main/java/org/batfish/representation/cisco/CiscoConfiguration.java, line 3458 at r1 (raw file):

                  _w.redFlag(
                      String.format(
                          "Could not determine src/dst IPs for tunnel %s", iface.getName()));

this will log the warning if the tunnel is IPsec, I am guessing that was not the intent

---

projects/batfish-common-protocol/src/main/java/org/batfish/datamodel/TunnelConfiguration.java, line 14 at r1 (raw file):

/**
 * Stores settings applicable to tunnel interfaces. Does not hanle IPSec configuration, for that see

typo in handle, also IPsec is the preferred case (sec in small)

[haverma]

Reviewed 2 of 2 files at r2.
Reviewable status: complete! all files reviewed, all discussions resolved

[codecov]

Codecov Report

Merging #4282 into master will increase coverage by 0.01%.
The diff coverage is 82.35%.

@@             Coverage Diff              @@
##             master    #4282      +/-   ##
============================================
+ Coverage     75.48%   75.49%   +0.01%     
- Complexity    25815    25825      +10     
============================================
  Files          2105     2106       +1     
  Lines        102350   102384      +34     
  Branches      12271    12276       +5     
============================================
+ Hits          77261    77298      +37     
+ Misses        19451    19439      -12     
- Partials       5638     5647       +9

Impacted Files	Coverage Δ	Complexity Δ
...src/main/java/org/batfish/datamodel/Interface.java	85.2% <66.66%> (-0.18%)	210 <2> (+2)
...ava/org/batfish/datamodel/TunnelConfiguration.java	80% <80%> (ø)	10 <10> (?)
...tfish/representation/cisco/CiscoConfiguration.java	84.73% <90%> (+0.64%)	533 <0> (+2)	⬆️
...java/org/batfish/symbolic/state/EdgeStateExpr.java	73.91% <0%> (-4.35%)	10% <0%> (-1%)
...c/main/java/org/batfish/dataplane/rib/RibTree.java	89.58% <0%> (-4.17%)	27% <0%> (-1%)
...src/main/java/org/batfish/coordinator/PoolMgr.java	64.04% <0%> (-1.13%)	15% <0%> (-1%)
...java/org/batfish/dataplane/ibdp/VirtualRouter.java	88.49% <0%> (-0.22%)	254% <0%> (-1%)
...rc/main/java/org/batfish/datamodel/flow/Trace.java	90.32% <0%> (+3.22%)	13% <0%> (+1%)	⬆️

[progwriter]

Reviewed 1 of 1 files at r3.
Reviewable status: complete! all files reviewed, all discussions resolved

---

projects/batfish/src/main/java/org/batfish/representation/cisco/CiscoConfiguration.java, line 3458 at r1 (raw file):

Previously, haverma (Harsh Verma) wrote…

this will log the warning if the tunnel is IPsec, I am guessing that was not the intent

done

---

projects/batfish-common-protocol/src/main/java/org/batfish/datamodel/TunnelConfiguration.java, line 14 at r1 (raw file):

Previously, haverma (Harsh Verma) wrote…

typo in handle, also IPsec is the preferred case (sec in small)

done