Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EIGRP: Flip to new EIGRP queue-based computation #4322

Merged
merged 1 commit into from
Jul 23, 2019

Conversation

progwriter
Copy link
Contributor

This flips the computation (calls in VirtualRouter, IncrementalBdpEngine) to the new route propagation, meaning tests like EigrpTest now use the new code.

After #4321

@progwriter progwriter requested a review from haverma July 23, 2019 07:24
@batfish-bot
Copy link

This change is Reviewable

@progwriter progwriter force-pushed the eigrp6 branch 2 times, most recently from e0038fd to c292c45 Compare July 23, 2019 16:48
@codecov
Copy link

codecov bot commented Jul 23, 2019

Codecov Report

Merging #4322 into master will decrease coverage by 0.04%.
The diff coverage is 100%.

@@             Coverage Diff              @@
##             master    #4322      +/-   ##
============================================
- Coverage     74.58%   74.54%   -0.05%     
+ Complexity    26077    26056      -21     
============================================
  Files          2128     2128              
  Lines        104618   104603      -15     
  Branches      12697    12695       -2     
============================================
- Hits          78033    77978      -55     
- Misses        20659    20695      +36     
- Partials       5926     5930       +4
Impacted Files Coverage Δ Complexity Δ
...rg/batfish/dataplane/ibdp/EigrpRoutingProcess.java 63.26% <ø> (+4.28%) 49 <0> (+3) ⬆️
...java/org/batfish/dataplane/ibdp/VirtualRouter.java 87.05% <100%> (-1.42%) 245 <5> (-8)
...g/batfish/dataplane/ibdp/IncrementalBdpEngine.java 83.62% <100%> (-6.77%) 77 <2> (-10)
...org/batfish/datamodel/flow/BidirectionalTrace.java 79.54% <0%> (-4.55%) 13% <0%> (-2%)
...java/org/batfish/datamodel/EigrpInternalRoute.java 71.69% <0%> (-3.78%) 9% <0%> (-2%)
...col/src/main/java/org/batfish/role/InferRoles.java 91.24% <0%> (-1.46%) 68% <0%> (-2%)
...c/main/java/org/batfish/dataplane/rib/RibTree.java 93.75% <0%> (+4.16%) 28% <0%> (+1%) ⬆️

Copy link

@haverma haverma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 3 of 3 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

Copy link

@haverma haverma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@haverma haverma merged commit 87aee56 into batfish:master Jul 23, 2019
@progwriter progwriter deleted the eigrp6 branch July 31, 2019 03:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants