Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cisco: more parsing under interface #4371

Merged
merged 1 commit into from
Jul 28, 2019

Conversation

progwriter
Copy link
Contributor

  • Parse "ip authentication..."
  • Parse "ip tcp ..."

* Parse "ip authentication..."
* Parse "ip tcp ..."
@progwriter progwriter requested a review from dhalperi July 28, 2019 01:41
@batfish-bot
Copy link

This change is Reviewable

@codecov
Copy link

codecov bot commented Jul 28, 2019

Codecov Report

Merging #4371 into master will decrease coverage by <.01%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #4371      +/-   ##
============================================
- Coverage      74.7%    74.7%   -0.01%     
+ Complexity    26147    26145       -2     
============================================
  Files          2134     2134              
  Lines        104728   104728              
  Branches      12693    12693              
============================================
- Hits          78242    78235       -7     
- Misses        20524    20525       +1     
- Partials       5962     5968       +6
Impacted Files Coverage Δ Complexity Δ
...java/org/batfish/symbolic/state/EdgeStateExpr.java 73.91% <0%> (-4.35%) 10% <0%> (-1%)
...col/src/main/java/org/batfish/role/InferRoles.java 91.24% <0%> (-1.46%) 68% <0%> (-2%)
...tfish/representation/cisco/CiscoConfiguration.java 84.53% <0%> (-0.13%) 514% <0%> (-1%)
...org/batfish/datamodel/flow/BidirectionalTrace.java 79.54% <0%> (ø) 13% <0%> (ø) ⬇️
.../src/main/java/org/batfish/datamodel/flow/Hop.java 60% <0%> (+6.66%) 6% <0%> (+1%) ⬆️

Copy link
Member

@dhalperi dhalperi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 6 of 6 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@progwriter progwriter merged commit 32f9558 into batfish:master Jul 28, 2019
@progwriter progwriter deleted the more-iface-parsing branch July 28, 2019 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants