Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cisco: allow unshutting interfaces #4375

Merged
merged 1 commit into from
Jul 29, 2019

Conversation

progwriter
Copy link
Contributor

No description provided.

@progwriter progwriter requested a review from arifogel July 29, 2019 20:06
@batfish-bot
Copy link

This change is Reviewable

@codecov
Copy link

codecov bot commented Jul 29, 2019

Codecov Report

Merging #4375 into master will decrease coverage by 0.15%.
The diff coverage is 100%.

@@             Coverage Diff              @@
##             master    #4375      +/-   ##
============================================
- Coverage     74.84%   74.69%   -0.16%     
+ Complexity    26338    26171     -167     
============================================
  Files          2135     2135              
  Lines        105614   104874     -740     
  Branches      12951    12690     -261     
============================================
- Hits          79050    78331     -719     
+ Misses        20613    20582      -31     
- Partials       5951     5961      +10
Impacted Files Coverage Δ Complexity Δ
...fish/grammar/cisco/CiscoControlPlaneExtractor.java 66.84% <100%> (-0.01%) 1473 <3> (ø)
...g/batfish/datamodel/eigrp/EigrpNeighborConfig.java 81.35% <0%> (-6.74%) 21% <0%> (-19%)
.../src/main/java/org/batfish/datamodel/flow/Hop.java 53.33% <0%> (-6.67%) 5% <0%> (-1%)
...g/batfish/dataplane/ibdp/IncrementalBdpEngine.java 90.28% <0%> (-3.93%) 77% <0%> (-17%)
...java/org/batfish/datamodel/EigrpExternalRoute.java 74.6% <0%> (-3.18%) 12% <0%> (-1%)
...org/batfish/datamodel/flow/BidirectionalTrace.java 79.54% <0%> (-2.28%) 13% <0%> (ø)
...tfish/representation/cisco/CiscoConfiguration.java 84.65% <0%> (-1.31%) 515% <0%> (-79%)
...rg/batfish/dataplane/ibdp/EigrpRoutingProcess.java 93.24% <0%> (-1.16%) 57% <0%> (-46%)
...src/main/java/org/batfish/coordinator/PoolMgr.java 64.04% <0%> (-1.13%) 15% <0%> (-1%)
...rg/batfish/datamodel/eigrp/EigrpTopologyUtils.java 81.11% <0%> (-1%) 21% <0%> (ø)
... and 1 more

Copy link
Member

@arifogel arifogel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 4 of 4 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

Copy link
Member

@arifogel arifogel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@progwriter progwriter merged commit c8190b1 into batfish:master Jul 29, 2019
@progwriter progwriter deleted the unshut-iface branch July 29, 2019 22:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants