Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

viModel question: remove edges #4418

Merged
merged 1 commit into from
Aug 8, 2019

Conversation

progwriter
Copy link
Contributor

Full rationale: https://docs.google.com/document/d/162gdCqqZ6M-eR6YIWeOQntcTcR_7GmVGOTz745ShULg/edit

TLDR: this edge data is not up to our newer standards; we do have edge questions that are better; this lets us stop maintaining a bunch of old code.

@progwriter progwriter requested a review from sfraint August 7, 2019 23:54
@batfish-bot
Copy link

This change is Reviewable

@codecov
Copy link

codecov bot commented Aug 8, 2019

Codecov Report

Merging #4418 into master will decrease coverage by 0.04%.
The diff coverage is 100%.

@@             Coverage Diff              @@
##             master    #4418      +/-   ##
============================================
- Coverage     75.17%   75.12%   -0.05%     
+ Complexity    26604    26567      -37     
============================================
  Files          2157     2154       -3     
  Lines        106169   106010     -159     
  Branches      12815    12799      -16     
============================================
- Hits          79808    79643     -165     
- Misses        20242    20243       +1     
- Partials       6119     6124       +5
Impacted Files Coverage Δ Complexity Δ
...in/java/org/batfish/datamodel/eigrp/EigrpEdge.java 77.77% <ø> (+16.9%) 9 <0> (ø) ⬇️
...va/org/batfish/question/VIModelQuestionPlugin.java 100% <100%> (+5.21%) 3 <1> (-1) ⬇️
...n/java/org/batfish/common/topology/Layer3Edge.java 62.5% <0%> (-21.88%) 11% <0%> (-1%)
...ava/org/batfish/datamodel/BgpActivePeerConfig.java 63.63% <0%> (-6.07%) 5% <0%> (-1%)
...src/main/java/org/batfish/coordinator/PoolMgr.java 59.55% <0%> (-4.5%) 13% <0%> (-2%)
...rc/main/java/org/batfish/datamodel/flow/Trace.java 87.09% <0%> (-3.23%) 12% <0%> (-1%)
...java/org/batfish/datamodel/EigrpExternalRoute.java 66.12% <0%> (-3.23%) 12% <0%> (-1%)
...va/org/batfish/datamodel/bgp/BgpTopologyUtils.java 80.51% <0%> (-2.6%) 57% <0%> (-4%)
...org/batfish/datamodel/flow/BidirectionalTrace.java 81.81% <0%> (-2.28%) 14% <0%> (ø)
.../org/batfish/datamodel/ospf/OspfTopologyUtils.java 92.39% <0%> (-2.18%) 27% <0%> (-1%)
... and 5 more

Copy link
Member

@sfraint sfraint left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 10 of 10 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@progwriter progwriter merged commit 98e69b9 into batfish:master Aug 8, 2019
@progwriter progwriter deleted the vi-remove-edges branch August 8, 2019 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants