Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IOS: parse EIGRP hello/hold timers #4421

Merged
merged 1 commit into from
Aug 8, 2019

Conversation

progwriter
Copy link
Contributor

Prevents us from jumping out of interface context.

Fixes #4048

@batfish-bot
Copy link

This change is Reviewable

@codecov
Copy link

codecov bot commented Aug 8, 2019

Codecov Report

Merging #4421 into master will decrease coverage by 0.81%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #4421      +/-   ##
============================================
- Coverage     75.98%   75.16%   -0.82%     
+ Complexity    27591    26604     -987     
============================================
  Files          2160     2157       -3     
  Lines        110421   106190    -4231     
  Branches      14148    12817    -1331     
============================================
- Hits          83902    79819    -4083     
+ Misses        20276    20248      -28     
+ Partials       6243     6123     -120
Impacted Files Coverage Δ Complexity Δ
...model/routing_policy/statement/SetEigrpMetric.java 52.94% <0%> (-19.79%) 4% <0%> (-4%)
...fish/grammar/cisco/CiscoControlPlaneExtractor.java 67.23% <0%> (-8.16%) 1479% <0%> (-636%)
.../src/main/java/org/batfish/datamodel/flow/Hop.java 53.33% <0%> (-6.67%) 5% <0%> (-1%)
...rc/main/java/org/batfish/datamodel/EigrpRoute.java 95% <0%> (-5%) 7% <0%> (-6%)
...java/org/batfish/symbolic/state/EdgeStateExpr.java 73.91% <0%> (-4.35%) 10% <0%> (-1%)
...c/main/java/org/batfish/dataplane/rib/RibTree.java 89.58% <0%> (-4.17%) 27% <0%> (-1%)
...org/batfish/representation/cisco/EigrpProcess.java 84.9% <0%> (-3.78%) 20% <0%> (-1%)
...tfish/representation/cisco/CiscoConfiguration.java 84.7% <0%> (-3.6%) 522% <0%> (-150%)
...rg/batfish/datamodel/eigrp/EigrpTopologyUtils.java 80.43% <0%> (-3.41%) 21% <0%> (-10%)
...rc/main/java/org/batfish/datamodel/flow/Trace.java 87.09% <0%> (-3.23%) 11% <0%> (-2%)
... and 14 more

Copy link
Member

@arifogel arifogel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 4 of 4 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

Copy link
Member

@arifogel arifogel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@arifogel arifogel merged commit 03fe738 into batfish:master Aug 8, 2019
@progwriter progwriter deleted the ios-eigrp-parsing branch August 8, 2019 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fail to parse Cisco tunnel interface config
3 participants