Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EIGRP distribute lists: improve filtering #4434

Merged
merged 1 commit into from
Aug 9, 2019

Conversation

progwriter
Copy link
Contributor

Filter routes that we are re-propagating in addition to ones we are redistributing.

Fixes #4392

Filter routes that we are re-propagating in addition to ones we are redistributing
@progwriter progwriter requested a review from haverma August 9, 2019 01:20
@batfish-bot
Copy link

This change is Reviewable

@codecov
Copy link

codecov bot commented Aug 9, 2019

Codecov Report

Merging #4434 into master will increase coverage by 0.01%.
The diff coverage is 100%.

@@             Coverage Diff              @@
##             master    #4434      +/-   ##
============================================
+ Coverage     75.15%   75.16%   +0.01%     
- Complexity    26633    26640       +7     
============================================
  Files          2154     2154              
  Lines        106185   106204      +19     
  Branches      12828    12829       +1     
============================================
+ Hits          79807    79832      +25     
+ Misses        20222    20218       -4     
+ Partials       6156     6154       -2
Impacted Files Coverage Δ Complexity Δ
...rg/batfish/dataplane/ibdp/EigrpRoutingProcess.java 93.51% <100%> (+0.5%) 70 <6> (+5) ⬆️
...col/src/main/java/org/batfish/role/InferRoles.java 92.33% <0%> (-0.37%) 69% <0%> (-1%)
...tfish/representation/cisco/CiscoConfiguration.java 84.52% <0%> (-0.13%) 523% <0%> (-1%)
...src/main/java/org/batfish/coordinator/WorkMgr.java 69.38% <0%> (+0.27%) 278% <0%> (+1%) ⬆️
...ain/java/org/batfish/coordinator/WorkQueueMgr.java 71.42% <0%> (+0.58%) 91% <0%> (+1%) ⬆️
...src/main/java/org/batfish/coordinator/PoolMgr.java 64.04% <0%> (+4.49%) 15% <0%> (+2%) ⬆️

Copy link

@haverma haverma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 5 of 5 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@haverma haverma merged commit 5a000ad into batfish:master Aug 9, 2019
@progwriter progwriter deleted the eigrp-fix-filtering branch June 4, 2020 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

EIGRP distribute-list does not work in some cases
3 participants