Update OSPF session compatibility question

[sfraint]

Update ospfSessionCompatibility to include unestablished/incompatible sessions, with a new Session_Status column.

Includes adding a new OSPF session status specifier.

[batfish-bot]

This change is 

[sfraint]

Reviewable status: 0 of 4 files reviewed, 1 unresolved discussion (waiting on @sfraint)

a discussion (no related file):
Still need to make the new column filterable

---

[codecov]

Codecov Report

Merging #4694 into master will decrease coverage by <.01%.
The diff coverage is 57.14%.

@@             Coverage Diff              @@
##             master    #4694      +/-   ##
============================================
- Coverage     75.76%   75.75%   -0.01%     
+ Complexity    27855    27852       -3     
============================================
  Files          2209     2209              
  Lines        109696   109700       +4     
  Branches      13216    13216              
============================================
- Hits          83106    83104       -2     
- Misses        20225    20229       +4     
- Partials       6365     6367       +2

Impacted Files	Coverage Δ	Complexity Δ
.../org/batfish/datamodel/ospf/OspfTopologyUtils.java	87.24% <0%> (-0.59%)	39 <0> (ø)
.../batfish/datamodel/ospf/CandidateOspfTopology.java	100% <100%> (ø)	6 <1> (ø)	⬇️
.../ospfsession/OspfSessionCompatibilityAnswerer.java	75.29% <58.33%> (-1.54%)	11 <0> (ø)
...g/batfish/datamodel/acl/IpAccessListLineIndex.java	33.33% <0%> (-5.56%)	4% <0%> (-1%)
...java/org/batfish/symbolic/state/EdgeStateExpr.java	73.91% <0%> (-4.35%)	10% <0%> (-1%)
...org/batfish/datamodel/flow/BidirectionalTrace.java	81.81% <0%> (-2.28%)	14% <0%> (-1%)
...tfish/representation/cisco/CiscoConfiguration.java	84.2% <0%> (-0.13%)	533% <0%> (-1%)
...col/src/main/java/org/batfish/role/InferRoles.java	92.33% <0%> (+1.09%)	69% <0%> (+1%)	⬆️

[progwriter]

Self review the nits

Reviewed 2 of 4 files at r1, 16 of 16 files at r2.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @sfraint)

---

projects/batfish-common-protocol/src/main/java/org/batfish/datamodel/ospf/CandidateOspfTopology.java, line 19 at r2 (raw file):

      new CandidateOspfTopology(ValueGraphBuilder.directed().build());

  @VisibleForTesting

if public then no need to really annotate.

---

projects/question/src/main/java/org/batfish/question/ospfsession/OspfSessionCompatibilityAnswerer.java, line 42 at r2 (raw file):

  static final String COL_REMOTE_IP = "Remote_IP";
  static final String COL_REMOTE_AREA = "Remote_Area";

nit: extra spacing

[ratulm]

@sfraint - In case it wasn't on your radar, Parameters.md needs updating too with the new specifier. (Can be a separate PR.)

[sfraint]

Reviewed 2 of 2 files at r3.
Reviewable status: complete! all files reviewed, all discussions resolved