NX-OS: flip new parser on by default #4718
Conversation
And update refs
|
This change is |
There was a problem hiding this comment.
Reviewed 5 of 7 files at r1.
Reviewable status: 5 of 7 files reviewed, 1 unresolved discussion (waiting on @arifogel and @dhalperi)
tests/parsing-tests/unit-tests-warnings.ref, line 2528 at r1 (raw file):
"Text" : "ip address 1.2.3.4/24 route-preference 10 tag 12345", "Parser_Context" : "[if_ip_address if_inner s_interface stanza cisco_configuration]", "Comment" : "Unsupported: route-preference declared in interface IP address"
Is this supported now? Same for other two that disappeared.
Codecov Report
@@ Coverage Diff @@
## master #4718 +/- ##
=========================================
Coverage 75.88% 75.88%
Complexity 28024 28024
=========================================
Files 2215 2215
Lines 110277 110277
Branches 13282 13282
=========================================
Hits 83687 83687
Misses 20186 20186
Partials 6404 6404 |
There was a problem hiding this comment.
Reviewable status: 5 of 7 files reviewed, 1 unresolved discussion (waiting on @arifogel)
tests/parsing-tests/unit-tests-warnings.ref, line 2528 at r1 (raw file):
Previously, arifogel (Ari Fogel) wrote…
Is this supported now? Same for other two that disappeared.
yes
There was a problem hiding this comment.
Reviewable status: 5 of 7 files reviewed, 1 unresolved discussion (waiting on @arifogel)
tests/parsing-tests/unit-tests-warnings.ref, line 2528 at r1 (raw file):
Previously, dhalperi (Dan Halperin) wrote…
yes
See the ConnectedRouteMetadata class and its new appearance in the refs.
There was a problem hiding this comment.
Reviewed 2 of 7 files at r1.
Reviewable status:complete! all files reviewed, all discussions resolved
And update refs