Dataplane changes for BGP next hop IP unchanged #4722
Conversation
|
This change is |
There was a problem hiding this comment.
Reviewed 4 of 5 files at r1, 1 of 1 files at r2.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @haverma)
projects/batfish/src/main/java/org/batfish/dataplane/ibdp/BgpRoutingProcess.java, line 827 at r2 (raw file):
Direction.OUT); // setting next hop IP for outgoing route
Why not move this to transformBgpRoutePostExport?
There was a problem hiding this comment.
Reviewable status: 2 of 7 files reviewed, all discussions resolved (waiting on @progwriter)
projects/batfish/src/main/java/org/batfish/dataplane/ibdp/BgpRoutingProcess.java, line 827 at r2 (raw file):
Previously, progwriter (Victor Heorhiadi) wrote…
Why not move this to
transformBgpRoutePostExport?
done, also for iBGP now checking if the next hop IP in the output builder was unset before setting it to anything. So that condition is not hit while exporting non BGP routes to BGP (where nhip would be present already).
There was a problem hiding this comment.
Reviewed 5 of 5 files at r3.
Reviewable status:complete! all files reviewed, all discussions resolved
Codecov Report
@@ Coverage Diff @@
## master #4722 +/- ##
=========================================
Coverage 75.38% 75.38%
Complexity 27894 27894
=========================================
Files 2215 2215
Lines 110548 110548
Branches 13337 13337
=========================================
Hits 83334 83334
Misses 20854 20854
Partials 6360 6360 |
UnchangedNextHopexpr to only apply when original route isBgpRoute