Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BgpProtocolHelper: clear next-hop-interface on import #4763

Merged
merged 2 commits into from
Sep 16, 2019

Conversation

dhalperi
Copy link
Member

No description provided.

@batfish-bot
Copy link

This change is Reviewable

Copy link
Contributor

@progwriter progwriter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

Copy link
Contributor

@progwriter progwriter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r2.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@dhalperi dhalperi merged commit 7d621bb into batfish:master Sep 16, 2019
@dhalperi dhalperi deleted the clear-next-hop branch September 16, 2019 19:03
@codecov
Copy link

codecov bot commented Sep 17, 2019

Codecov Report

Merging #4763 into master will decrease coverage by 0.01%.
The diff coverage is 100%.

@@             Coverage Diff              @@
##             master    #4763      +/-   ##
============================================
- Coverage     75.46%   75.44%   -0.02%     
+ Complexity    28425    28415      -10     
============================================
  Files          2279     2279              
  Lines        111499   111500       +1     
  Branches      13372    13372              
============================================
- Hits          84138    84126      -12     
- Misses        20950    20959       +9     
- Partials       6411     6415       +4
Impacted Files Coverage Δ Complexity Δ
...batfish/dataplane/protocols/BgpProtocolHelper.java 95.61% <100%> (+0.03%) 41 <0> (ø) ⬇️
.../src/main/java/org/batfish/datamodel/flow/Hop.java 53.33% <0%> (-6.67%) 5% <0%> (-1%)
...java/org/batfish/symbolic/state/EdgeStateExpr.java 73.91% <0%> (-4.35%) 10% <0%> (-1%)
...c/main/java/org/batfish/dataplane/rib/RibTree.java 89.58% <0%> (-4.17%) 27% <0%> (-1%)
...rc/main/java/org/batfish/datamodel/flow/Trace.java 87.09% <0%> (-3.23%) 11% <0%> (-2%)
...org/batfish/datamodel/flow/BidirectionalTrace.java 81.81% <0%> (-2.28%) 14% <0%> (ø)
...src/main/java/org/batfish/coordinator/PoolMgr.java 64.04% <0%> (-1.13%) 15% <0%> (-1%)
...rg/batfish/dataplane/ibdp/EigrpRoutingProcess.java 93.12% <0%> (-0.39%) 69% <0%> (-1%)
...col/src/main/java/org/batfish/role/InferRoles.java 90.9% <0%> (-0.38%) 65% <0%> (-1%)
...java/org/batfish/dataplane/ibdp/VirtualRouter.java 87.87% <0%> (-0.34%) 251% <0%> (-2%)
... and 1 more

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants