Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add next hop interface to routes diff answerer columns #4803

Merged
merged 2 commits into from
Sep 21, 2019
Merged

Conversation

haverma
Copy link

@haverma haverma commented Sep 20, 2019

No description provided.

@batfish-bot
Copy link

This change is Reviewable

Copy link
Contributor

@progwriter progwriter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 4 of 4 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @dhalperi)

@codecov
Copy link

codecov bot commented Sep 20, 2019

Codecov Report

Merging #4803 into master will decrease coverage by 0.01%.
The diff coverage is 100%.

@@             Coverage Diff              @@
##             master    #4803      +/-   ##
============================================
- Coverage     75.43%   75.41%   -0.02%     
+ Complexity    28545    28534      -11     
============================================
  Files          2281     2281              
  Lines        112119   112123       +4     
  Branches      13483    13484       +1     
============================================
- Hits          84579    84560      -19     
- Misses        21069    21084      +15     
- Partials       6471     6479       +8
Impacted Files Coverage Δ Complexity Δ
...va/org/batfish/question/routes/RoutesAnswerer.java 83.21% <100%> (+0.24%) 10 <0> (ø) ⬇️
...rg/batfish/question/routes/RoutesAnswererUtil.java 92.16% <100%> (+0.04%) 109 <0> (+2) ⬆️
...src/main/java/org/batfish/coordinator/PoolMgr.java 59.55% <0%> (-5.62%) 13% <0%> (-3%)
...java/org/batfish/symbolic/state/EdgeStateExpr.java 73.91% <0%> (-4.35%) 10% <0%> (-1%)
...c/main/java/org/batfish/dataplane/rib/RibTree.java 89.58% <0%> (-4.17%) 27% <0%> (-1%)
...org/batfish/datamodel/flow/BidirectionalTrace.java 81.81% <0%> (-2.28%) 14% <0%> (ø)
...ain/java/org/batfish/coordinator/WorkQueueMgr.java 70.84% <0%> (-0.59%) 90% <0%> (-1%)
...rg/batfish/dataplane/ibdp/EigrpRoutingProcess.java 93.12% <0%> (-0.39%) 69% <0%> (-1%)
...col/src/main/java/org/batfish/role/InferRoles.java 92.04% <0%> (-0.38%) 66% <0%> (-1%)
...java/org/batfish/dataplane/ibdp/VirtualRouter.java 87.63% <0%> (-0.34%) 252% <0%> (-2%)
... and 4 more

Copy link
Contributor

@progwriter progwriter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r2.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @dhalperi)

@haverma haverma merged commit 949809c into master Sep 21, 2019
@haverma haverma deleted the add-nh-iface branch September 21, 2019 00:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants