Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

F5 BIG-IP IMISH OSPFv2 parsing #4812

Merged
merged 1 commit into from
Sep 24, 2019

Conversation

arifogel
Copy link
Member

No description provided.

@batfish-bot
Copy link

This change is Reviewable

Copy link
Member

@dhalperi dhalperi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 14 of 14 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @progwriter)

@arifogel arifogel merged commit 77272d0 into batfish:master Sep 24, 2019
@arifogel arifogel deleted the ari-f5-imish-ospf-parsing branch September 24, 2019 23:08
@codecov
Copy link

codecov bot commented Sep 24, 2019

Codecov Report

Merging #4812 into master will decrease coverage by <.01%.
The diff coverage is 87.5%.

@@             Coverage Diff              @@
##             master    #4812      +/-   ##
============================================
- Coverage     75.47%   75.47%   -0.01%     
+ Complexity    28645    28643       -2     
============================================
  Files          2283     2283              
  Lines        112552   112560       +8     
  Branches      13518    13519       +1     
============================================
- Hits          84954    84951       -3     
- Misses        21108    21113       +5     
- Partials       6490     6496       +6
Impacted Files Coverage Δ Complexity Δ
..._bigip_imish/F5BigipImishConfigurationBuilder.java 90.94% <100%> (+0.2%) 70 <3> (+3) ⬆️
...f5_bigip_imish/parsing/F5BigipImishBaseParser.java 62.5% <50%> (-4.17%) 4 <1> (+1)
...org/batfish/datamodel/flow/BidirectionalTrace.java 79.54% <0%> (-2.28%) 13% <0%> (-1%)
...ava/org/batfish/datamodel/bgp/Layer2VniConfig.java 80% <0%> (-2%) 13% <0%> (-1%)
...col/src/main/java/org/batfish/role/InferRoles.java 90.9% <0%> (-1.52%) 65% <0%> (-2%)
...rg/batfish/dataplane/ibdp/EigrpRoutingProcess.java 93.12% <0%> (-0.39%) 69% <0%> (-1%)
...tfish/representation/cisco/CiscoConfiguration.java 78.67% <0%> (-0.12%) 517% <0%> (-1%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants