Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

F5 BIG-IP IMISH OSPF extraction #4819

Merged
merged 4 commits into from
Sep 25, 2019

Conversation

arifogel
Copy link
Member

No description provided.

@batfish-bot
Copy link

This change is Reviewable

Copy link
Contributor

@progwriter progwriter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 9 of 12 files at r1, 3 of 3 files at r2, 2 of 2 files at r3.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @dhalperi)

@dhalperi
Copy link
Member

-reviewer:@dhalperi

@dhalperi dhalperi removed their request for review September 25, 2019 18:59
Copy link
Contributor

@progwriter progwriter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r4.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@codecov
Copy link

codecov bot commented Sep 25, 2019

Codecov Report

Merging #4819 into master will increase coverage by 0.02%.
The diff coverage is 92.59%.

@@             Coverage Diff              @@
##             master    #4819      +/-   ##
============================================
+ Coverage     75.47%   75.49%   +0.02%     
- Complexity    28648    28707      +59     
============================================
  Files          2283     2291       +8     
  Lines        112573   112749     +176     
  Branches      13526    13529       +3     
============================================
+ Hits          84962    85122     +160     
- Misses        21110    21124      +14     
- Partials       6501     6503       +2
Impacted Files Coverage Δ Complexity Δ
.../representation/f5_bigip/F5BigipStructureType.java 100% <100%> (ø) 3 <0> (ø) ⬇️
...g/batfish/representation/f5_bigip/OspfProcess.java 100% <100%> (ø) 7 <7> (?)
...representation/f5_bigip/F5BigipStructureUsage.java 100% <100%> (ø) 3 <0> (ø) ⬇️
.../representation/f5_bigip/F5BigipConfiguration.java 94.29% <100%> (+0.04%) 233 <2> (+2) ⬆️
...batfish/representation/f5_bigip/OspfInterface.java 100% <100%> (ø) 3 <3> (?)
...tfish/representation/f5_bigip/OspfNetworkType.java 100% <100%> (ø) 1 <1> (?)
...g/batfish/representation/f5_bigip/OspfNetwork.java 100% <100%> (ø) 3 <3> (?)
..._bigip_imish/F5BigipImishConfigurationBuilder.java 90.44% <86.48%> (-0.63%) 81 <11> (+9)
...atfish/representation/f5_bigip/ImishInterface.java 87.5% <87.5%> (ø) 4 <4> (?)
...rg/batfish/dataplane/ibdp/EigrpRoutingProcess.java 93.12% <0%> (-0.39%) 69% <0%> (-1%)
... and 13 more

@arifogel arifogel merged commit b83549b into batfish:master Sep 25, 2019
@arifogel arifogel deleted the ari-f5-imish-ospf-extraction branch September 25, 2019 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants