iptables fixes #488
Merged
iptables fixes #488
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add test rig that shows this
|
This partially resolves #485, but I believe that there are further issues that need to be investigated by someone else. |
* Also includes iptables for routers, this should make sure we dont break this feature again going forward * Fixes batfish#464
|
We've added another commit with a new iptables testrig that does more comprehensive tests. |
arifogel
reviewed
Oct 5, 2017
| "answerElements" : [ | ||
| { | ||
| "class" : "org.batfish.datamodel.FlowHistory" | ||
| } |
There was a problem hiding this comment.
Is this supposed to be empty? What about the other reachability answers?
There was a problem hiding this comment.
Yes all three questions are supposed to be empty. A non empty result is a violation of the policy. The questions are crafted so they return no results.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes two things:
:FORWARD ACCEPT [0:0]style of defaults (iptables-save doesn't require it, so neither should batfish)