Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PAN BGP: peer addresses, ASN, route reflector parsing and extraction #4880

Merged
merged 2 commits into from
Oct 4, 2019

Conversation

dhalperi
Copy link
Member

@dhalperi dhalperi commented Oct 4, 2019

No description provided.

@batfish-bot
Copy link

This change is Reviewable

@codecov
Copy link

codecov bot commented Oct 4, 2019

Codecov Report

Merging #4880 into master will decrease coverage by <.01%.
The diff coverage is 85.29%.

@@             Coverage Diff              @@
##             master    #4880      +/-   ##
============================================
- Coverage     76.21%    76.2%   -0.01%     
- Complexity    29002    29008       +6     
============================================
  Files          2302     2302              
  Lines        112497   112531      +34     
  Branches      13449    13451       +2     
============================================
+ Hits          85736    85757      +21     
- Misses        20210    20217       +7     
- Partials       6551     6557       +6
Impacted Files Coverage Δ Complexity Δ
.../org/batfish/representation/palo_alto/BgpPeer.java 100% <100%> (ø) 13 <8> (+8) ⬆️
...presentation/palo_alto/PaloAltoStructureUsage.java 100% <100%> (ø) 3 <0> (ø) ⬇️
...rammar/palo_alto/PaloAltoConfigurationBuilder.java 82.78% <70.58%> (-0.26%) 267 <4> (+4)
...java/org/batfish/symbolic/state/EdgeStateExpr.java 73.91% <0%> (-4.35%) 10% <0%> (-1%)
...c/main/java/org/batfish/dataplane/rib/RibTree.java 89.58% <0%> (-4.17%) 27% <0%> (-1%)
...src/main/java/org/batfish/coordinator/PoolMgr.java 64.04% <0%> (-1.13%) 15% <0%> (-1%)
...java/org/batfish/dataplane/ibdp/VirtualRouter.java 87.69% <0%> (-0.33%) 255% <0%> (-2%)
...batfish/src/main/java/org/batfish/main/Driver.java 38.3% <0%> (-0.25%) 28% <0%> (ø)

Copy link
Contributor

@progwriter progwriter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 7 of 7 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @sfraint)

@dhalperi dhalperi merged commit 36fe6a9 into batfish:master Oct 4, 2019
@dhalperi dhalperi deleted the pan-bgp-peer-group-2 branch October 4, 2019 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants