Cisco IOS-XR communities v2

[arifogel]

• update data model to support needed primitives
• better testing of existing data model

[batfish-bot]

This change is 

[codecov]

Codecov Report

Merging #4883 into master will increase coverage by 0.09%.
The diff coverage is 93.94%.

@@             Coverage Diff              @@
##             master    #4883      +/-   ##
============================================
+ Coverage      76.2%    76.3%   +0.09%     
- Complexity    29016    29167     +151     
============================================
  Files          2302     2311       +9     
  Lines        112532   112839     +307     
  Branches      13451    13463      +12     
============================================
+ Hits          85759    86103     +344     
+ Misses        20215    20175      -40     
- Partials       6558     6561       +3

Impacted Files	Coverage Δ	Complexity Δ
...batfish/datamodel/routing_policy/expr/IntExpr.java	100% <ø> (ø)	1 <0> (ø)	⬇️
...l/routing_policy/communities/CommunityContext.java	100% <ø> (+1.75%)	14 <0> (ø)	⬇️
.../batfish/datamodel/routing_policy/expr/VarInt.java	76% <0%> (+76%)	9 <0> (+9)	⬆️
.../routing_policy/communities/CommunitySetExprs.java	100% <100%> (ø)	2 <2> (?)
...tfish/representation/cisco/CiscoConfiguration.java	84.21% <100%> (+0.09%)	510 <4> (+3)	⬆️
.../routing_policy/communities/CommunityExprsSet.java	100% <100%> (ø)	11 <11> (?)
.../routing_policy/communities/CommunitySetUnion.java	100% <100%> (+11.76%)	11 <7> (ø)	⬇️
...ing_policy/communities/CommunityExprEvaluator.java	100% <100%> (ø)	3 <3> (?)
...h/representation/cisco/XrCommunitySetIosRegex.java	100% <100%> (ø)	3 <3> (?)
...ish/representation/juniper/PsThenCommunityAdd.java	90.9% <100%> (ø)	3 <0> (ø)	⬇️
... and 80 more

[dhalperi]

---

projects/batfish/src/main/java/org/batfish/representation/cisco/CiscoConversions.java.orig, line 209 at r1 (raw file):

      final Configuration c,
      CryptoMapEntry cryptoMapEntry,
      String cryptoMapNameSeqNumber,

delete this file?

[dhalperi]

Reviewed 24 of 91 files at r1.
Reviewable status: 24 of 91 files reviewed, 1 unresolved discussion (waiting on @arifogel, @dhalperi, and @progwriter)

[dhalperi]

Reviewed 67 of 91 files at r1, 1 of 2 files at r2.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @progwriter)