Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PAN BGP: initial peer conversion #4884

Merged
merged 1 commit into from
Oct 4, 2019
Merged

Conversation

dhalperi
Copy link
Member

@dhalperi dhalperi commented Oct 4, 2019

No description provided.

@batfish-bot
Copy link

This change is Reviewable

Copy link
Contributor

@progwriter progwriter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 8 of 8 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @sfraint)

@codecov
Copy link

codecov bot commented Oct 4, 2019

Codecov Report

Merging #4884 into master will decrease coverage by 0.01%.
The diff coverage is 50.72%.

@@             Coverage Diff              @@
##             master    #4884      +/-   ##
============================================
- Coverage      76.2%   76.18%   -0.02%     
- Complexity    29014    29018       +4     
============================================
  Files          2302     2302              
  Lines        112532   112593      +61     
  Branches      13451    13461      +10     
============================================
+ Hits          85757    85781      +24     
- Misses        20215    20243      +28     
- Partials       6560     6569       +9
Impacted Files Coverage Δ Complexity Δ
...batfish/representation/palo_alto/BgpPeerGroup.java 77.77% <100%> (+2.77%) 8 <3> (+1) ⬆️
.../org/batfish/representation/palo_alto/BgpPeer.java 100% <100%> (ø) 14 <2> (+1) ⬆️
...va/org/batfish/representation/palo_alto/BgpVr.java 100% <100%> (ø) 14 <1> (ø) ⬇️
...rammar/palo_alto/PaloAltoConfigurationBuilder.java 82.78% <100%> (ø) 267 <0> (ø) ⬇️
...epresentation/palo_alto/PaloAltoConfiguration.java 86.04% <42.37%> (-4.09%) 189 <4> (+4)
...ain/java/org/batfish/symbolic/IngressLocation.java 65.78% <0%> (-2.64%) 15% <0%> (-1%)
...tfish/representation/cisco/CiscoConfiguration.java 83.99% <0%> (-0.13%) 506% <0%> (-1%)
...rg/batfish/dataplane/ibdp/EigrpRoutingProcess.java 93.51% <0%> (+0.38%) 70% <0%> (+1%) ⬆️

@dhalperi dhalperi merged commit 940364a into batfish:master Oct 4, 2019
@dhalperi dhalperi deleted the pan-bgp-peer branch October 4, 2019 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants