FRR: Extract and convert match as-path

[corinaminer]

No description provided.

[batfish-bot]

This change is 

[corinaminer]

Reviewable status: 0 of 7 files reviewed, 2 unresolved discussions (waiting on @progwriter and @yifeiyuan)

---

projects/batfish/src/main/java/org/batfish/grammar/cumulus_frr/CumulusFrrConfigurationBuilder.java, line 692 at r1 (raw file):

  public void exitRmm_as_path(Rmm_as_pathContext ctx) {
    String name = ctx.name.getText();
    _currentRouteMapEntry.setMatchAsPath(new RouteMapMatchAsPath(name));

based on GNS3 experimentation it doesn't look like multiple as-path access lists can have an effect in the same route-map term

---

projects/batfish/src/main/java/org/batfish/representation/cumulus/CumulusNcluConfiguration.java, line 1100 at r1 (raw file):

    markConcreteStructure(CumulusStructureType.INTERFACE);
    markConcreteStructure(
        CumulusStructureType.IP_AS_PATH_ACCESS_LIST, CumulusStructureUsage.ROUTE_MAP_MATCH_AS_PATH);

why don't any of the other markConcreteStructure() calls include usages?

[codecov]

Codecov Report

Merging #4906 into master will increase coverage by <.01%.
The diff coverage is 100%.

@@             Coverage Diff              @@
##             master    #4906      +/-   ##
============================================
+ Coverage     76.33%   76.33%   +<.01%     
- Complexity    29281    29283       +2     
============================================
  Files          2321     2322       +1     
  Lines        113195   113211      +16     
  Branches      13489    13489              
============================================
+ Hits          86402    86415      +13     
- Misses        20215    20216       +1     
- Partials       6578     6580       +2

Impacted Files	Coverage Δ	Complexity Δ
...ar/cumulus_frr/CumulusFrrConfigurationBuilder.java	81.23% <100%> (+0.24%)	96 <1> (+1)	⬆️
...sh/representation/cumulus/RouteMapMatchAsPath.java	100% <100%> (ø)	4 <4> (?)
.../representation/cumulus/CumulusStructureUsage.java	100% <100%> (ø)	3 <0> (ø)	⬇️
...presentation/cumulus/CumulusNcluConfiguration.java	92.74% <100%> (ø)	232 <0> (ø)	⬇️
.../batfish/representation/cumulus/RouteMapEntry.java	100% <100%> (ø)	31 <3> (+2)	⬆️
.../src/main/java/org/batfish/datamodel/flow/Hop.java	53.33% <0%> (-6.67%)	5% <0%> (-1%)
...java/org/batfish/symbolic/state/EdgeStateExpr.java	73.91% <0%> (-4.35%)	10% <0%> (-1%)
...rc/main/java/org/batfish/datamodel/flow/Trace.java	87.09% <0%> (-3.23%)	11% <0%> (-2%)
...org/batfish/datamodel/flow/BidirectionalTrace.java	81.81% <0%> (-2.28%)	14% <0%> (-1%)
...col/src/main/java/org/batfish/role/InferRoles.java	90.15% <0%> (-1.52%)	63% <0%> (-2%)
... and 8 more

[dhalperi]

Reviewed 7 of 7 files at r1.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @corinaminer, @progwriter, and @yifeiyuan)

---

projects/batfish/src/main/java/org/batfish/representation/cumulus/CumulusNcluConfiguration.java, line 1100 at r1 (raw file):

Previously, corinaminer (Corina Miner) wrote…

why don't any of the other markConcreteStructure() calls include usages?

No longer required -- follow the link for one of the other marks.

[corinaminer]

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @progwriter and @yifeiyuan)

---

projects/batfish/src/main/java/org/batfish/representation/cumulus/CumulusNcluConfiguration.java, line 1100 at r1 (raw file):

Previously, dhalperi (Dan Halperin) wrote…

No longer required -- follow the link for one of the other marks.

Nice, got it

[dhalperi]

Reviewed 1 of 1 files at r2.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @progwriter and @yifeiyuan)