Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ISPs: prefer confederation ASNs #4956

Merged
merged 1 commit into from
Oct 11, 2019
Merged

Conversation

progwriter
Copy link
Contributor

Since ISPs are external to any network, prefer confederation remote ASes over the peer's local AS.

@batfish-bot
Copy link

This change is Reviewable

@codecov
Copy link

codecov bot commented Oct 11, 2019

Codecov Report

Merging #4956 into master will increase coverage by <.01%.
The diff coverage is 100%.

@@             Coverage Diff              @@
##             master    #4956      +/-   ##
============================================
+ Coverage     76.55%   76.55%   +<.01%     
- Complexity    29823    29826       +3     
============================================
  Files          2384     2384              
  Lines        115025   115027       +2     
  Branches      13592    13592              
============================================
+ Hits          88056    88064       +8     
+ Misses        20299    20290       -9     
- Partials       6670     6673       +3
Impacted Files Coverage Δ Complexity Δ
...java/org/batfish/common/util/IspModelingUtils.java 92.65% <100%> (+0.05%) 35 <0> (ø) ⬇️
...rg/batfish/dataplane/ibdp/EigrpRoutingProcess.java 93.12% <0%> (-0.39%) 69% <0%> (-1%)
...col/src/main/java/org/batfish/role/InferRoles.java 90.15% <0%> (-0.38%) 63% <0%> (-1%)
...tfish/representation/cisco/CiscoConfiguration.java 84.12% <0%> (+0.12%) 510% <0%> (+1%) ⬆️
...main/java/org/batfish/datamodel/BgpPeerConfig.java 91.8% <0%> (+1.63%) 40% <0%> (ø) ⬇️
...org/batfish/datamodel/flow/BidirectionalTrace.java 81.81% <0%> (+2.27%) 14% <0%> (+1%) ⬆️
...rc/main/java/org/batfish/datamodel/flow/Trace.java 90.32% <0%> (+3.22%) 13% <0%> (+2%) ⬆️
.../src/main/java/org/batfish/datamodel/flow/Hop.java 60% <0%> (+6.66%) 6% <0%> (+1%) ⬆️

Copy link

@haverma haverma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 2 of 2 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@haverma haverma merged commit b1e912b into batfish:master Oct 11, 2019
@progwriter progwriter deleted the isp-confed branch June 4, 2020 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants